Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: src/code-stubs.h

Issue 1150263002: JavaScript stubs have access to their calling convention and minor key now. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 4c683edef54f422acb5580371e134512f9fa95d9..6db4a79e387b85103d3372a1a7f9209891d24956 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -355,11 +355,6 @@ struct FakeStubForTesting : public CodeStub {
Handle<Code> GenerateCode() override; \
DEFINE_CODE_STUB(NAME, SUPER)
-#define DEFINE_TURBOFAN_CODE_STUB(NAME, SUPER) \
- public: \
- const char* GetFunctionName() const override { return #NAME "_STUB"; } \
- DEFINE_CODE_STUB(NAME, SUPER)
-
#define DEFINE_HANDLER_CODE_STUB(NAME, SUPER) \
public: \
Handle<Code> GenerateCode() override; \
@@ -533,8 +528,6 @@ class TurboFanCodeStub : public CodeStub {
Code::StubType GetStubType() const override { return Code::FAST; }
- virtual const char* GetFunctionName() const = 0;
-
protected:
explicit TurboFanCodeStub(Isolate* isolate) : CodeStub(isolate) {}
@@ -615,7 +608,7 @@ class MathFloorStub : public TurboFanCodeStub {
int GetStackParameterCount() const override { return 1; }
DEFINE_CALL_INTERFACE_DESCRIPTOR(MathRoundVariant);
- DEFINE_TURBOFAN_CODE_STUB(MathFloor, TurboFanCodeStub);
+ DEFINE_CODE_STUB(MathFloor, TurboFanCodeStub);
};
@@ -628,7 +621,7 @@ class StringLengthTFStub : public TurboFanCodeStub {
ExtraICState GetExtraICState() const override { return Code::LOAD_IC; }
DEFINE_CALL_INTERFACE_DESCRIPTOR(LoadWithVector);
- DEFINE_TURBOFAN_CODE_STUB(StringLengthTF, TurboFanCodeStub);
+ DEFINE_CODE_STUB(StringLengthTF, TurboFanCodeStub);
};
@@ -671,7 +664,7 @@ class StringAddTFStub : public TurboFanCodeStub {
void PrintBaseName(std::ostream& os) const override; // NOLINT
DEFINE_CALL_INTERFACE_DESCRIPTOR(StringAdd);
- DEFINE_TURBOFAN_CODE_STUB(StringAddTF, TurboFanCodeStub);
+ DEFINE_CODE_STUB(StringAddTF, TurboFanCodeStub);
};
« no previous file with comments | « no previous file | src/code-stubs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698