Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Issue 1150253005: Replace BoxDimensions with sky.Size (Closed)

Created:
5 years, 6 months ago by abarth-chromium
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -47 lines) Patch
M sky/examples/raw/render_paragraph.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M sky/examples/raw/sector-layout.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/sdk/lib/framework/fn2.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M sky/sdk/lib/framework/layout2.dart View 6 chunks +14 lines, -32 lines 0 comments Download
M sky/tests/raw/render_flex.dart View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
abarth-chromium
5 years, 6 months ago (2015-05-28 21:23:18 UTC) #1
Hixie
lgtm
5 years, 6 months ago (2015-05-28 21:26:58 UTC) #2
abarth-chromium
5 years, 6 months ago (2015-05-28 21:29:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
68d5118082ec76583fe3a4ce97ae8f577f38b19d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698