Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1150253003: Trivial patch to set a max lookback on reordering (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Trivial patch to set a max lookback on reordering BUG=skia: Committed: https://skia.googlesource.com/skia/+/2a97c55ae3b2b62fef2045e839600dc13b481c4c

Patch Set 1 #

Patch Set 2 : tweaks #

Total comments: 1

Patch Set 3 : tidy #

Patch Set 4 : tidy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/gpu/GrReorderCommandBuilder.cpp View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
joshualitt
ptal
5 years, 7 months ago (2015-05-22 15:57:57 UTC) #2
bsalomon
lgtm https://codereview.chromium.org/1150253003/diff/20001/src/gpu/GrReorderCommandBuilder.cpp File src/gpu/GrReorderCommandBuilder.cpp (right): https://codereview.chromium.org/1150253003/diff/20001/src/gpu/GrReorderCommandBuilder.cpp#newcode23 src/gpu/GrReorderCommandBuilder.cpp:23: static const int kLookback = 10; kMaxLookBack?
5 years, 7 months ago (2015-05-22 16:03:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150253003/60001
5 years, 7 months ago (2015-05-22 18:14:05 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 18:19:48 UTC) #7
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/2a97c55ae3b2b62fef2045e839600dc13b481c4c

Powered by Google App Engine
This is Rietveld 408576698