Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1150223003: Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions… (Closed)

Created:
5 years, 7 months ago by vaibhav1.a
Modified:
5 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Subsituting pattern ScopedVector push_back.(ptr.release()) with push_back(ptr.Pass()) in extensions/browser BUG=457697 Committed: https://crrev.com/37e26d0ef803a93a1c7578cc308ae6492fe50d3b Cr-Commit-Position: refs/heads/master@{#331738}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M extensions/browser/web_ui_user_script_loader.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
vaibhav1.a
Patch uploaded successfully, Kindly Review.
5 years, 7 months ago (2015-05-22 07:30:18 UTC) #2
vaibhav1.a
Patch uploaded successfully. Kindly review.
5 years, 7 months ago (2015-05-27 06:50:20 UTC) #4
Ken Rockot(use gerrit already)
lgtm
5 years, 7 months ago (2015-05-27 21:05:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150223003/1
5 years, 6 months ago (2015-05-28 03:08:01 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-05-28 04:03:45 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 04:05:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/37e26d0ef803a93a1c7578cc308ae6492fe50d3b
Cr-Commit-Position: refs/heads/master@{#331738}

Powered by Google App Engine
This is Rietveld 408576698