chrome/browser/ui/android/infobars/infobar_android.cc - Issue 1150193004: Straighten up life cycle of native InfoBar pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/infobars/infobar_android.cc

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed setNativeInfoBarPtr calls from child classes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBar.java ('K') | « chrome/browser/ui/android/infobars/infobar_android.h ('k') | chrome/browser/ui/android/infobars/save_password_infobar.cc » ('j') | chrome/browser/ui/android/infobars/translate_infobar.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/infobars/infobar_android.cc

diff --git a/chrome/browser/ui/android/infobars/infobar_android.cc b/chrome/browser/ui/android/infobars/infobar_android.cc

index 137eb7469bc87493e0afabe8db2469e7024d41ca..c00d4f9453cef75b42f9facc99bc4e62e0a9c269 100644

--- a/chrome/browser/ui/android/infobars/infobar_android.cc

+++ b/chrome/browser/ui/android/infobars/infobar_android.cc

@@ -35,6 +35,9 @@ void InfoBarAndroid::set_java_infobar(

const base::android::JavaRef<jobject>& java_info_bar) {

DCHECK(java_info_bar_.is_null());

java_info_bar_.Reset(java_info_bar);

+ JNIEnv* env = base::android::AttachCurrentThread();

+ Java_InfoBar_setNativeInfoBar(env, java_info_bar.obj(),

+ reinterpret_cast<intptr_t>(this));

}

bool InfoBarAndroid::HasSetJavaInfoBar() const {