chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java - Issue 1150193004: Straighten up life cycle of native InfoBar pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: removed setNativeInfoBarPtr calls from child classes Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/infobar/ConfirmInfoBar.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBar.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/infobar/DownloadOverwriteInfoBar.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBar.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java

index 9ae5ac5f50e1589862e174ef0f5b40329ea2e8ed..483d357055c1fa5823221255ebdf2a6b67e7d062 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java

@@ -36,10 +36,9 @@ public class DataReductionProxyInfoBarDelegate {

* passing it to this function.

@CalledByNative

- InfoBar showDataReductionProxyInfoBar(long nativeInfoBar, int enumeratedIconId) {

+ InfoBar showDataReductionProxyInfoBar(int enumeratedIconId) {

int drawableId = ResourceId.mapToDrawableId(enumeratedIconId);

- DataReductionProxyInfoBar infoBar = new DataReductionProxyInfoBar(

- nativeInfoBar, drawableId);

+ DataReductionProxyInfoBar infoBar = new DataReductionProxyInfoBar(drawableId);

return infoBar;

}