Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3668)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unrelated file Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
index 41d128333bdd9692db4ab79570940cac97b56c71..acb412240969a9cf04e7738baf9b05dc90ea77e6 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/SavePasswordInfoBar.java
@@ -24,19 +24,18 @@ public class SavePasswordInfoBar extends ConfirmInfoBar {
private final String mTitle;
@CalledByNative
- private static InfoBar show(long nativeInfoBar, int enumeratedIconId, String message,
- int titleLinkStart, int titleLinkEnd, String primaryButtonText,
- String secondaryButtonText, boolean isMoreButtonNeeded) {
- return new SavePasswordInfoBar(nativeInfoBar, ResourceId.mapToDrawableId(enumeratedIconId),
- message, titleLinkStart, titleLinkEnd, primaryButtonText, secondaryButtonText,
+ private static InfoBar show(int enumeratedIconId, String message, int titleLinkStart,
+ int titleLinkEnd, String primaryButtonText, String secondaryButtonText,
+ boolean isMoreButtonNeeded) {
+ return new SavePasswordInfoBar(ResourceId.mapToDrawableId(enumeratedIconId), message,
+ titleLinkStart, titleLinkEnd, primaryButtonText, secondaryButtonText,
isMoreButtonNeeded);
}
- private SavePasswordInfoBar(long nativeInfoBar, int iconDrawbleId, String message,
- int titleLinkStart, int titleLinkEnd, String primaryButtonText,
- String secondaryButtonText, boolean isMoreButtonNeeded) {
- super(nativeInfoBar, null, iconDrawbleId, null, message, null, primaryButtonText,
- secondaryButtonText);
+ private SavePasswordInfoBar(int iconDrawbleId, String message, int titleLinkStart,
+ int titleLinkEnd, String primaryButtonText, String secondaryButtonText,
+ boolean isMoreButtonNeeded) {
+ super(null, iconDrawbleId, null, message, null, primaryButtonText, secondaryButtonText);
mIsMoreButtonNeeded = isMoreButtonNeeded;
mTitleLinkRangeStart = titleLinkStart;
mTitleLinkRangeEnd = titleLinkEnd;

Powered by Google App Engine
This is Rietveld 408576698