Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4686)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unrelated file Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java
index 9ae5ac5f50e1589862e174ef0f5b40329ea2e8ed..ca54d0d7e73e1b73450cde3c15c0559c4544157e 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/infobar/DataReductionProxyInfoBarDelegate.java
@@ -30,18 +30,16 @@ public class DataReductionProxyInfoBarDelegate {
/**
* Creates and begins the process for showing a DataReductionProxyInfoBarDelegate.
- * @param nativeInfoBar Pointer to the C++ InfoBar corresponding to the Java InfoBar.
* @param enumeratedIconId ID corresponding to the icon that will be shown for the InfoBar.
* The ID must have been mapped using the ResourceMapper class before
* passing it to this function.
*/
@CalledByNative
- InfoBar showDataReductionProxyInfoBar(long nativeInfoBar, int enumeratedIconId) {
+ InfoBar showDataReductionProxyInfoBar(int enumeratedIconId) {
int drawableId = ResourceId.mapToDrawableId(enumeratedIconId);
- DataReductionProxyInfoBar infoBar = new DataReductionProxyInfoBar(
- nativeInfoBar, drawableId);
+ DataReductionProxyInfoBar infoBar = new DataReductionProxyInfoBar(drawableId);
return infoBar;
}
- protected static native void nativeLaunch(WebContents webContents, String linkUrl);
+ private static native void nativeLaunch(WebContents webContents, String linkUrl);
}

Powered by Google App Engine
This is Rietveld 408576698