Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3962)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBarDelegate.java

Issue 1150193004: Straighten up life cycle of native InfoBar pointers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: removed unrelated file Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBarDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBarDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBarDelegate.java
deleted file mode 100644
index 00d9d4024f892454557df6893835b1cfa76531e4..0000000000000000000000000000000000000000
--- a/chrome/android/java/src/org/chromium/chrome/browser/infobar/TranslateInfoBarDelegate.java
+++ /dev/null
@@ -1,52 +0,0 @@
-// Copyright 2013 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-package org.chromium.chrome.browser.infobar;
-
-import org.chromium.base.CalledByNative;
-
-/**
- * Translate JNI methods
- */
-public class TranslateInfoBarDelegate {
- private TranslateInfoBar mInfoBar;
-
- private TranslateInfoBarDelegate() {}
-
- @CalledByNative
- public static TranslateInfoBarDelegate create() {
- return new TranslateInfoBarDelegate();
- }
-
- @CalledByNative
- boolean changeTranslateInfoBarTypeAndPointer(
- long newNativeInfoBar, int translateBarType) {
- mInfoBar.changeInfoBarTypeAndNativePointer(
- translateBarType, newNativeInfoBar);
- return true;
- }
-
- @CalledByNative
- InfoBar showTranslateInfoBar(
- long nativeInfoBar, int translateBarType,
- int sourceLanguageIndex, int targetLanguageIndex, boolean autoTranslatePair,
- boolean showNeverInfobar, boolean triggeredFromMenu,
- String[] languages) {
- mInfoBar = new TranslateInfoBar(nativeInfoBar, this, translateBarType,
- sourceLanguageIndex, targetLanguageIndex, autoTranslatePair, showNeverInfobar,
- triggeredFromMenu, languages);
- return mInfoBar;
- }
-
- public void applyTranslateOptions(long nativeTranslateInfoBar,
- int sourceLanguageIndex, int targetLanguageIndex, boolean alwaysTranslate,
- boolean neverTranslateLanguage, boolean neverTranslateSite) {
- nativeApplyTranslateOptions(nativeTranslateInfoBar, sourceLanguageIndex,
- targetLanguageIndex, alwaysTranslate, neverTranslateLanguage, neverTranslateSite);
- }
-
- private native void nativeApplyTranslateOptions(long nativeTranslateInfoBar,
- int sourceLanguageIndex, int targetLanguageIndex, boolean alwaysTranslate,
- boolean neverTranslateLanguage, boolean neverTranslateSite);
-}

Powered by Google App Engine
This is Rietveld 408576698