Issue 1150183010: Add error recovery for abbreviations outside blocks in bitcode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1150183010: Add error recovery for abbreviations outside blocks in bitcode. (Closed)

Created:
5 years, 6 months ago by Karl

Modified:
5 years, 6 months ago

Reviewers:
jvoung (off chromium), Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-llvm.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Add error recovery for abbreviations outside blocks in bitcode. Adds error recovery to the bitcode munger writer that handles abbreviation definitions that do not appear in any block (not allowed by the bitcode writer). BUG=None R=jvoung@chromium.org Committed: https://chromium.googlesource.com/native_client/pnacl-llvm/+/9ef1f408be60958dfb35082e4c4fe9be9e9ca7db

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -0 lines)			Patch
	M	lib/Bitcode/NaCl/TestUtils/NaClBitcodeMungeWriter.cpp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	unittests/Bitcode/NaClMungeWriteErrorTests.cpp	View	1	1 chunk	+17 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

jvoung (off chromium)

Is it possible to add a NaClMungeWriteErrorTests test (or is there one that didn't tickle ...

5 years, 6 months ago (2015-06-02 16:40:43 UTC) #3

Karl

5 years, 6 months ago (2015-06-02 17:06:51 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
9ef1f408be60958dfb35082e4c4fe9be9e9ca7db (presubmit successful).