Laying the groundwork for targeting WinRT.

Laying the groundwork for targeting WinRT for WebRTC.

Now supporting various flavors of WinRT in the target_os argument.
Setting compiler and linker flags so cc files are compiled
to support C++/CX syntax.

This is part of a larger effort to port WebRTC to WinRT.

Committed: https://crrev.com/56f81e32556d513af513eac0710f2e85877ffa3b
Cr-Commit-Position: refs/heads/master@{#340893}

[fredlebel, 2015-06-02 16:10:06]

fredlebel@macadamian.com changed reviewers:
+ brettw@chromium.org

[fredlebel, 2015-06-15 20:54:03]

On 2015/06/02 16:10:06, fredlebel wrote:
> mailto:fredlebel@macadamian.com changed reviewers:
> + mailto:brettw@chromium.org

There hasn't been any movement on this CR since it's been posted.  Should other
reviewers be added?  If so, who else could review these GN changes?

Thanks

[brettw, 2015-06-19 17:21:12]

I don't understand the background here. You mention that this is part of a
larger effort. Do you have a link to a bug or previous discussion?

I'm quite surprised we would be trying to compile in WinRT. What is your goal
here? It's my understanding that Chrome can't be made to run in the WinRT
sandbox due to conflicts with Chrome's sandbox and the JIT-ed JavaScript code.

[fredlebel, 2015-06-22 15:06:01]

On 2015/06/19 17:21:12, brettw wrote:
> I don't understand the background here. You mention that this is part of a
> larger effort. Do you have a link to a bug or previous discussion?
> 
> I'm quite surprised we would be trying to compile in WinRT. What is your goal
> here? It's my understanding that Chrome can't be made to run in the WinRT
> sandbox due to conflicts with Chrome's sandbox and the JIT-ed JavaScript code.

Definitely something I should have mentioned in the original message.
This is part of our effort to port the WebRTC library to WinRT.
The WebRTC build architecture currently depends on Chromium and its
dependencies.
We're only porting those dependencies necessary for WebRTC.
Unfortunately this means touching many shared GN files in Chromium.

[brettw, 2015-06-22 17:16:33]

Thanks for the clarification, that makes more sense.

I'm trying really hard to keep flags out of BUILDCONFIG to avoid the
overwhelming common.gypi problem we had before.

I think this might make more sense as a cross-compile. Your change makes Yasm
work, but all other "host" targets will need similar treatment. I think instead
the target system should be winrt, and then when it wants a tool like yasm or
the symbol extractor, it depends on the host toolchain version of that tool,
just like it would for any other cross compile.

If we did this, I think it would look like the following:

- To do a WinRT build, you would set target_os = "winrt". In BUILDCONFIG when it
sets up is_win, etc. you would change it to:
  if (current_os == "win" || current_os == "winrt") {
so is_win will still be set, but the variants can be differentiated if necessary
by checking the exact os string.

- You would make a new winrt toolchain in build/toolchain/win/BUILD.gn next to
the current ones and the clang ones. You'll need to plumb "current_os" through
the toolchain_args of the msvc toolchain template. See
build/toolchain/gcc_toolchain.gni for an example.

- At the bottom of BUILDCONFIG you would set up the "...winrt_x64" toolchain to
be the default toolchain when the target_os is "winrt"

[fredlebel, 2015-06-30 23:17:02]

Switched to a cross-compile way of targeting WinRT.

Thanks for the help.

[fredlebel, 2015-07-16 16:33:05]

When can we expect this CR to be reviewed and merged?

[brettw, 2015-07-22 05:06:23]

Sorry, this has been on the bottom of my todo list. Will look tomorrow.

[brettw, 2015-07-22 20:29:20]

lgtm

https://codereview.chromium.org/1150183009/diff/20001/build/config/BUILDCONFI...
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/1150183009/diff/20001/build/config/BUILDCONFI...
build/config/BUILDCONFIG.gn:540: } else {  # WinRT variants
Just eliminate this and make the whole thing one big if/else block.

https://codereview.chromium.org/1150183009/diff/20001/build/config/compiler/B...
File build/config/compiler/BUILD.gn (right):

https://codereview.chromium.org/1150183009/diff/20001/build/config/compiler/B...
build/config/compiler/BUILD.gn:577: if (is_win && current_os == "win") {
This line reads very strangely to me since they seem to be saying the same
thing. Maybe swap these two cases, and be sure to put a WinRT comment first, so
it's

  if (is_win && current_os != "win") {
    # WindowsRT: use the dynamic CRT.
    ...
  } else {
    # Desktop Windows.
    ...
  }

https://codereview.chromium.org/1150183009/diff/20001/build/toolchain/win/BUI...
File build/toolchain/win/BUILD.gn (right):

https://codereview.chromium.org/1150183009/diff/20001/build/toolchain/win/BUI...
build/toolchain/win/BUILD.gn:233: if (current_cpu == "x86") {
You can delete the two inner conditions. You can define as many toolchains as
you want. I realize the code above this does the same thing but that should be
fixed at some point (you don't have to).

[fredlebel, 2015-07-24 16:22:05]

Addressed all three comments.

[fredlebel, 2015-07-28 19:11:34]

The CQ bit was checked by fredlebel@macadamian.com

[fredlebel, 2015-07-28 19:11:34]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1150183009/#ps40001
(title: "Addressed review comments.")

[fredlebel, 2015-07-28 19:11:44]

The CQ bit was unchecked by fredlebel@macadamian.com

[fredlebel, 2015-07-28 19:13:19]

The CQ bit was checked by fredlebel@macadamian.com

[commit-bot: I haz the power, 2015-07-28 19:14:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150183009/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1150183009/40001

[commit-bot: I haz the power, 2015-07-28 19:16:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-28 19:16:50]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[fredlebel, 2015-07-28 20:35:28]

The CQ bit was checked by fredlebel@macadamian.com

[fredlebel, 2015-07-28 20:35:28]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1150183009/#ps60001
(title: "Rebased on master to fix merge conflicts.")

[commit-bot: I haz the power, 2015-07-28 20:35:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150183009/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1150183009/60001

[commit-bot: I haz the power, 2015-07-28 20:45:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-28 20:45:56]

Try jobs failed on following builders:
  win8_chromium_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/...)

[fredlebel, 2015-07-28 21:10:08]

The CQ bit was checked by fredlebel@macadamian.com

[fredlebel, 2015-07-28 21:10:08]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1150183009/#ps80001
(title: "Added check for key in toolchain before changing it.")

[commit-bot: I haz the power, 2015-07-28 21:10:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150183009/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1150183009/80001

[commit-bot: I haz the power, 2015-07-28 21:19:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-28 21:19:15]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[fredlebel, 2015-07-29 15:19:59]

The CQ bit was checked by fredlebel@macadamian.com

[fredlebel, 2015-07-29 15:20:00]

The patchset sent to the CQ was uploaded after l-g-t-m from brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1150183009/#ps40002
(title: "Added Macadamian to the AUTHORS.")

[commit-bot: I haz the power, 2015-07-29 15:20:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1150183009/40002
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1150183009/40002

[commit-bot: I haz the power, 2015-07-29 15:50:11]

Committed patchset #6 (id:40002)

[commit-bot: I haz the power, 2015-07-29 15:50:48]

Patchset 6 (id:??) landed as
https://crrev.com/56f81e32556d513af513eac0710f2e85877ffa3b
Cr-Commit-Position: refs/heads/master@{#340893}