Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 1150183007: Re-land: bindings: Use MessageEventInit for MessageEvent constructor (Closed)

Created:
5 years, 6 months ago by bashi
Modified:
5 years, 6 months ago
Reviewers:
haraken
CC:
blink-reviews, blink-reviews-dom_chromium.org, arv+blink, vivekg_samsung, sof, eae+blinkwatch, vivekg, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Re-land: bindings: Use MessageEventInit for MessageEvent constructor The previous CL was reverted because it broke browser tests. We should make sure that MessageEvent.port is non-null when it is created via WebDOMMessageEvent::initMessageEvent() because content layer uses it to implement postMessage(). Original description: This CL also includes some behavior changes to improve spec conformance. - MessageEvent.ports becomes nullable. If a given MessageEventInit doesn't have a value for |ports|, MessageEvent.ports is initialized with null. Note that when Blink creates MessageEvent as a result of postMessage(), |ports| should be an empty array when there is no ports. - MessageEvent.data is initialized to null when no |data| is specified. BUG=433179, 492798 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196118

Patch Set 1 #

Total comments: 3

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+117 lines, -86 lines) Patch
M LayoutTests/fast/events/constructors/message-event-constructor.html View 4 chunks +5 lines, -5 lines 0 comments Download
M LayoutTests/fast/events/constructors/message-event-constructor-expected.txt View 4 chunks +27 lines, -27 lines 0 comments Download
M LayoutTests/fast/events/message-event-source-getter-remove-child-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8MessageEventCustom.cpp View 3 chunks +8 lines, -23 lines 0 comments Download
M Source/bindings/scripts/v8_dictionary.py View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/core.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/dom/MessagePort.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/events/MessageEvent.h View 4 chunks +7 lines, -12 lines 0 comments Download
M Source/core/events/MessageEvent.cpp View 5 chunks +35 lines, -11 lines 0 comments Download
M Source/core/events/MessageEvent.idl View 1 chunk +8 lines, -6 lines 0 comments Download
A Source/core/events/MessageEventInit.idl View 1 chunk +16 lines, -0 lines 0 comments Download
M Source/web/WebDOMMessageEvent.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
bashi
PTAL? https://codereview.chromium.org/1150183007/diff/1/Source/web/WebDOMMessageEvent.cpp File Source/web/WebDOMMessageEvent.cpp (right): https://codereview.chromium.org/1150183007/diff/1/Source/web/WebDOMMessageEvent.cpp#newcode60 Source/web/WebDOMMessageEvent.cpp:60: if (!ports.get()) This is the only diff from ...
5 years, 6 months ago (2015-05-29 02:05:42 UTC) #2
haraken
LGTM
5 years, 6 months ago (2015-05-29 02:12:06 UTC) #3
haraken
https://codereview.chromium.org/1150183007/diff/1/Source/web/WebDOMMessageEvent.cpp File Source/web/WebDOMMessageEvent.cpp (right): https://codereview.chromium.org/1150183007/diff/1/Source/web/WebDOMMessageEvent.cpp#newcode60 Source/web/WebDOMMessageEvent.cpp:60: if (!ports.get()) On 2015/05/29 02:05:42, bashi1 wrote: > This ...
5 years, 6 months ago (2015-05-29 02:12:57 UTC) #4
bashi
https://codereview.chromium.org/1150183007/diff/1/Source/web/WebDOMMessageEvent.cpp File Source/web/WebDOMMessageEvent.cpp (right): https://codereview.chromium.org/1150183007/diff/1/Source/web/WebDOMMessageEvent.cpp#newcode60 Source/web/WebDOMMessageEvent.cpp:60: if (!ports.get()) On 2015/05/29 02:12:57, haraken wrote: > On ...
5 years, 6 months ago (2015-05-29 02:40:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150183007/20001
5 years, 6 months ago (2015-05-29 02:40:44 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-05-29 03:53:00 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196118

Powered by Google App Engine
This is Rietveld 408576698