|
Re-land: bindings: Use MessageEventInit for MessageEvent constructor
The previous CL was reverted because it broke browser tests.
We should make sure that MessageEvent.port is non-null when it is created
via WebDOMMessageEvent::initMessageEvent() because content layer uses it
to implement postMessage().
Original description:
This CL also includes some behavior changes to improve spec conformance.
- MessageEvent.ports becomes nullable. If a given MessageEventInit doesn't
have a value for |ports|, MessageEvent.ports is initialized with null.
Note that when Blink creates MessageEvent as a result of postMessage(),
|ports| should be an empty array when there is no ports.
- MessageEvent.data is initialized to null when no |data| is specified.
BUG= 433179, 492798
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196118
Total comments: 3
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+117 lines, -86 lines) |
Patch |
 |
M |
LayoutTests/fast/events/constructors/message-event-constructor.html
|
View
|
|
4 chunks |
+5 lines, -5 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/events/constructors/message-event-constructor-expected.txt
|
View
|
|
4 chunks |
+27 lines, -27 lines |
0 comments
|
Download
|
 |
M |
LayoutTests/fast/events/message-event-source-getter-remove-child-expected.txt
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/bindings/core/v8/custom/V8MessageEventCustom.cpp
|
View
|
|
3 chunks |
+8 lines, -23 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/scripts/v8_dictionary.py
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/core.gypi
|
View
|
|
2 chunks |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/core/dom/MessagePort.cpp
|
View
|
|
1 chunk |
+3 lines, -1 line |
0 comments
|
Download
|
 |
M |
Source/core/events/MessageEvent.h
|
View
|
|
4 chunks |
+7 lines, -12 lines |
0 comments
|
Download
|
 |
M |
Source/core/events/MessageEvent.cpp
|
View
|
|
5 chunks |
+35 lines, -11 lines |
0 comments
|
Download
|
 |
M |
Source/core/events/MessageEvent.idl
|
View
|
|
1 chunk |
+8 lines, -6 lines |
0 comments
|
Download
|
 |
A |
Source/core/events/MessageEventInit.idl
|
View
|
|
1 chunk |
+16 lines, -0 lines |
0 comments
|
Download
|
 |
M |
Source/web/WebDOMMessageEvent.cpp
|
View
|
1
|
1 chunk |
+4 lines, -0 lines |
0 comments
|
Download
|
Total messages: 9 (3 generated)
|