Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1150183005: Add a very simple RenderParagraph example using LayoutRoot. (Closed)

Created:
5 years, 6 months ago by eseidel
Modified:
5 years, 6 months ago
Reviewers:
Hixie
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add a very simple RenderParagraph example using LayoutRoot. I'm sure we'll want something more sophisticated in the near future. Next step is to actually animate this updating layout. R=ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/72257148569097a9e4b993e8ea4af8230e0d44e7

Patch Set 1 #

Total comments: 3

Patch Set 2 : Add support for minWidth #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -29 lines) Patch
A + sky/examples/raw/render_paragraph.dart View 1 2 chunks +42 lines, -29 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
eseidel
5 years, 6 months ago (2015-05-28 18:41:29 UTC) #2
Hixie
lgtm https://codereview.chromium.org/1150183005/diff/1/sky/examples/raw/render_paragraph.dart File sky/examples/raw/render_paragraph.dart (right): https://codereview.chromium.org/1150183005/diff/1/sky/examples/raw/render_paragraph.dart#newcode1 sky/examples/raw/render_paragraph.dart:1: // Copyright 2015 The Chromium Authors. All rights ...
5 years, 6 months ago (2015-05-28 19:14:29 UTC) #3
eseidel
5 years, 6 months ago (2015-05-28 19:19:01 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
72257148569097a9e4b993e8ea4af8230e0d44e7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698