remoting/codec/video_encoder.h - Issue 1150163002: Update VideoFramePump to pass un-changed frames to encoders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/codec/video_encoder.h

Issue 1150163002: Update VideoFramePump to pass un-changed frames to encoders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add basic tests for unchanged frames Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: remoting/codec/video_encoder.h

diff --git a/remoting/codec/video_encoder.h b/remoting/codec/video_encoder.h

index f497eb3b4c3839b6acad5a7968d35f70c2ee8d04..467977b7166f2a84338a15d66d4a100e7474f67f 100644

--- a/remoting/codec/video_encoder.h

+++ b/remoting/codec/video_encoder.h

@@ -25,7 +25,10 @@ class VideoEncoder {

virtual void SetLosslessEncode(bool want_lossless) {}

virtual void SetLosslessColor(bool want_lossless) {}

- // Encode an image stored in |frame|.

+ // Encode an image stored in |frame|. If |frame.uupdated_region()| is empty

Sergey Ulanov 2015/06/09 05:32:44 typo: uupdated

Wez 2015/06/09 22:00:37 Done.

+ // then the encoder may return a packet (e.g. to top-off previously-encoded

+ // portions of the frame to higher quality) or return nullptr to indicate that

+ // there is no work to do.

virtual scoped_ptr<VideoPacket> Encode(const webrtc::DesktopFrame& frame) = 0;

};

« remoting/codec/codec_test.cc ('K') | « remoting/codec/codec_test.cc ('k') | remoting/codec/video_encoder_verbatim.cc » ('j') | remoting/host/video_frame_pump_unittest.cc » ('J')