Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: remoting/codec/video_encoder.h

Issue 1150163002: Update VideoFramePump to pass un-changed frames to encoders. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tweak comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/codec/video_encoder_verbatim.cc » ('j') | remoting/codec/video_encoder_vpx.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/codec/video_encoder.h
diff --git a/remoting/codec/video_encoder.h b/remoting/codec/video_encoder.h
index f497eb3b4c3839b6acad5a7968d35f70c2ee8d04..467977b7166f2a84338a15d66d4a100e7474f67f 100644
--- a/remoting/codec/video_encoder.h
+++ b/remoting/codec/video_encoder.h
@@ -25,7 +25,10 @@ class VideoEncoder {
virtual void SetLosslessEncode(bool want_lossless) {}
virtual void SetLosslessColor(bool want_lossless) {}
- // Encode an image stored in |frame|.
+ // Encode an image stored in |frame|. If |frame.uupdated_region()| is empty
+ // then the encoder may return a packet (e.g. to top-off previously-encoded
+ // portions of the frame to higher quality) or return nullptr to indicate that
+ // there is no work to do.
virtual scoped_ptr<VideoPacket> Encode(const webrtc::DesktopFrame& frame) = 0;
};
« no previous file with comments | « no previous file | remoting/codec/video_encoder_verbatim.cc » ('j') | remoting/codec/video_encoder_vpx.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698