Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 1150033010: Add README.md for win_toolchain (Closed)

Created:
5 years, 6 months ago by scottmg
Modified:
5 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Target Ref:
refs/heads/master
Project:
tools
Visibility:
Public.

Description

Add README.md for win_toolchain I started to build a package for setting up a VS2015 bot, and realized I didn't really remember how the toolchain setup worked. So I wrote a readme for this directory. I see I will live to regret putting way too many "2013"s in various places in these scripts. :/ R=dpranke@chromium.org BUG=492774 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=295437

Patch Set 1 #

Patch Set 2 : 80col #

Total comments: 2

Patch Set 3 : merge bullets #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -0 lines) Patch
A win_toolchain/README.md View 1 2 1 chunk +74 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
scottmg
5 years, 6 months ago (2015-05-27 23:30:25 UTC) #1
Dirk Pranke
lgtm w/ one comment. https://codereview.chromium.org/1150033010/diff/20001/win_toolchain/README.md File win_toolchain/README.md (right): https://codereview.chromium.org/1150033010/diff/20001/win_toolchain/README.md#newcode10 win_toolchain/README.md:10: the paths, version numbers, etc. ...
5 years, 6 months ago (2015-05-28 01:21:18 UTC) #2
scottmg
https://codereview.chromium.org/1150033010/diff/20001/win_toolchain/README.md File win_toolchain/README.md (right): https://codereview.chromium.org/1150033010/diff/20001/win_toolchain/README.md#newcode10 win_toolchain/README.md:10: the paths, version numbers, etc. On 2015/05/28 01:21:18, Dirk ...
5 years, 6 months ago (2015-05-28 02:08:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1150033010/40001
5 years, 6 months ago (2015-05-28 02:10:39 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-05-28 02:12:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=295437

Powered by Google App Engine
This is Rietveld 408576698