Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(816)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 1150003003: Cleanup ScrollableArea scrolling API (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/frame/FrameView.h ('k') | Source/core/frame/RootFrameViewportTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index d2f308350872ea4aa90113b78f477a5a2a38fa3b..fbaf10c328a1c08751e39ea685d263d40e828370 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -1501,10 +1501,10 @@ void FrameView::setScrollPosition(const DoublePoint& scrollPoint, ScrollType scr
if (scrollBehavior == ScrollBehaviorInstant) {
DoubleSize newOffset(newScrollPosition.x(), newScrollPosition.y());
// TODO(bokan): Why do we need to go through updateScrollbars? If not, we can
- // just delete this whole method and use the base version.
+ // just delete this behavior switch and use the base method.
updateScrollbars(newOffset);
} else {
- ScrollableArea::setScrollPosition(newScrollPosition, ProgrammaticScroll, ScrollBehaviorSmooth);
+ ScrollableArea::setScrollPosition(newScrollPosition, scrollType, ScrollBehaviorSmooth);
}
}
« no previous file with comments | « Source/core/frame/FrameView.h ('k') | Source/core/frame/RootFrameViewportTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698