Oilpan: Build fix after r196496

Oilpan: Build fix after r196496

This CL fixes a compile error when we enable ENABLE_LAZY_SWEEPING on non-oilpan builds.

TBR=sigbjornf@opera.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196641

[haraken, 2015-06-08 01:12:00]

Committed patchset #1 (id:1) manually as 196641 (presubmit successful).

[haraken, 2015-06-08 01:12:46]

haraken@chromium.org changed reviewers:
+ oilpan-reviews@chromium.org

[sof, 2015-06-08 06:27:59]

lgtm, but i think we should make DEALRE_EAGER_FINALIZATION_OPERATOR_NEW() expand
to empty for ENABLE(LAZY_SWEEPING) && !ENABLE(OILPAN) in Heap.h, so we don't
need to adjust downstream uses.

[haraken, 2015-06-08 06:31:44]

On 2015/06/08 06:27:59, sof wrote:
> lgtm, but i think we should make DEALRE_EAGER_FINALIZATION_OPERATOR_NEW()
expand
> to empty for ENABLE(LAZY_SWEEPING) && !ENABLE(OILPAN) in Heap.h, so we don't
> need to adjust downstream uses.

Ah, that makes more sense. Will upload a fix.

[haraken, 2015-06-08 06:35:25]

On 2015/06/08 06:31:44, haraken wrote:
> On 2015/06/08 06:27:59, sof wrote:
> > lgtm, but i think we should make DEALRE_EAGER_FINALIZATION_OPERATOR_NEW()
> expand
> > to empty for ENABLE(LAZY_SWEEPING) && !ENABLE(OILPAN) in Heap.h, so we don't
> > need to adjust downstream uses.
> 
> Ah, that makes more sense. Will upload a fix.

Hmm, it might not make sense, because:

class A : public RefCountedWillBeGarabageCollected<A> {
  DECLARE_EAGER_FINALIZATION_OPERATOR_NEW();  // This should be empty when
!ENABLE(OILPAN).
};

class B : public GarabageCollected<B> {
  DECLARE_EAGER_FINALIZATION_OPERATOR_NEW();  // This should not be empty when
!ENABLE(OILPAN).
};

So I think ENABLE(OILPAN) needs to be annotated in the class itself (not in
Heap.h).

[sof, 2015-06-08 06:42:32]

On 2015/06/08 06:35:25, haraken wrote:
> On 2015/06/08 06:31:44, haraken wrote:
> > On 2015/06/08 06:27:59, sof wrote:
> > > lgtm, but i think we should make DEALRE_EAGER_FINALIZATION_OPERATOR_NEW()
> > expand
> > > to empty for ENABLE(LAZY_SWEEPING) && !ENABLE(OILPAN) in Heap.h, so we
don't
> > > need to adjust downstream uses.
> > 
> > Ah, that makes more sense. Will upload a fix.
> 
> Hmm, it might not make sense, because:
> 
> class A : public RefCountedWillBeGarabageCollected<A> {
>   DECLARE_EAGER_FINALIZATION_OPERATOR_NEW();  // This should be empty when
> !ENABLE(OILPAN).
> };
> 
> class B : public GarabageCollected<B> {
>   DECLARE_EAGER_FINALIZATION_OPERATOR_NEW();  // This should not be empty when
> !ENABLE(OILPAN).
> };
> 
> So I think ENABLE(OILPAN) needs to be annotated in the class itself (not in
> Heap.h).

We need to reign in the combinations & complexity asap.. quite right, eager
sweeping/finalization is enabled with ENABLE(LAZY_SWEEPING), not dependent on
OILPAN.

So, yes, the way it is done in this CL is the one that will work.