Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1149973006: Fix incorrect paint invalidations with accelerated 2D canvas (Closed)

Created:
5 years, 7 months ago by Justin Novosad
Modified:
5 years, 7 months ago
Reviewers:
Stephen White
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix incorrect paint invalidations with accelerated 2D canvas In cases where a canvas is accelerated, its content are separated into a compositor layer. When propagating invalidations through that layer, invalidation rectangles need to be expressed relative to the layer's origin, which is the top left corner of the canvas's content box. Before this change, coordinates were relative to the canvas's layout box, which is correct for non-accelerated cases. BUG=490106 TEST=/fast/canvas/canvas-incremental-repaint-3.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195817

Patch Set 1 #

Patch Set 2 : using similarity 100 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -3 lines) Patch
A LayoutTests/fast/canvas/canvas-incremental-repaint-3.html View 1 1 chunk +51 lines, -0 lines 0 comments Download
A LayoutTests/fast/canvas/canvas-incremental-repaint-3-expected.html View 1 chunk +20 lines, -0 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +9 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Justin Novosad
PTAL
5 years, 7 months ago (2015-05-22 16:17:12 UTC) #2
Stephen White
LGTM
5 years, 7 months ago (2015-05-22 20:26:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149973006/20001
5 years, 7 months ago (2015-05-22 20:38:37 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-22 23:07:50 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195817

Powered by Google App Engine
This is Rietveld 408576698