Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 1149963004: Sync various event interfaces with their specs (Closed)

Created:
5 years, 6 months ago by philipj_slow
Modified:
5 years, 6 months ago
Reviewers:
Rick Byers
CC:
blink-reviews, vivekg, arv+blink, Inactive, vivekg_samsung
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Sync various event interfaces with their specs There are no changes to the generated code other than the canBubble->bubbles argument renaming. BUG=460722 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196525

Patch Set 1 #

Total comments: 3

Patch Set 2 : spec URL update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M Source/core/events/EventListener.idl View 1 chunk +2 lines, -1 line 0 comments Download
M Source/core/events/MutationEvent.idl View 1 chunk +6 lines, -8 lines 0 comments Download
M Source/core/events/NavigatorEvents.idl View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/events/OverflowEvent.idl View 2 chunks +1 line, -1 line 0 comments Download
M Source/core/events/OverflowEventInit.idl View 1 chunk +1 line, -2 lines 0 comments Download
M Source/core/events/PointerEvent.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/events/PointerEventInit.idl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
philipj_slow
PTAL, this is the last large chunk of event interfaces, then it's onwards to core/f* ...
5 years, 6 months ago (2015-06-03 21:31:04 UTC) #2
Rick Byers
LGTM with nit https://codereview.chromium.org/1149963004/diff/1/Source/core/events/PointerEvent.idl File Source/core/events/PointerEvent.idl (right): https://codereview.chromium.org/1149963004/diff/1/Source/core/events/PointerEvent.idl#newcode5 Source/core/events/PointerEvent.idl:5: // https://dvcs.w3.org/hg/pointerevents/raw-file/tip/pointerEvents.html#pointerevent-interface Actually, we've moved the ...
5 years, 6 months ago (2015-06-04 15:57:56 UTC) #3
philipj_slow
https://codereview.chromium.org/1149963004/diff/1/Source/core/events/PointerEvent.idl File Source/core/events/PointerEvent.idl (right): https://codereview.chromium.org/1149963004/diff/1/Source/core/events/PointerEvent.idl#newcode5 Source/core/events/PointerEvent.idl:5: // https://dvcs.w3.org/hg/pointerevents/raw-file/tip/pointerEvents.html#pointerevent-interface On 2015/06/04 15:57:55, Rick Byers wrote: > ...
5 years, 6 months ago (2015-06-04 16:58:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149963004/20001
5 years, 6 months ago (2015-06-04 18:07:16 UTC) #7
Rick Byers
On 2015/06/04 16:58:25, philipj wrote: > https://codereview.chromium.org/1149963004/diff/1/Source/core/events/PointerEvent.idl > File Source/core/events/PointerEvent.idl (right): > > https://codereview.chromium.org/1149963004/diff/1/Source/core/events/PointerEvent.idl#newcode5 > ...
5 years, 6 months ago (2015-06-04 19:37:35 UTC) #8
commit-bot: I haz the power
5 years, 6 months ago (2015-06-04 20:27:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196525

Powered by Google App Engine
This is Rietveld 408576698