Issue 1149923009: Be sure to skip objects inside out-of-flow subtrees.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1149923009: Be sure to skip objects inside out-of-flow subtrees. (Closed)

Created:
5 years, 6 months ago by mstensho (USE GERRIT)

Modified:
5 years, 6 months ago

Reviewers:
dsinclair, Julien - ping for review

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, mstensho (USE GERRIT), pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Be sure to skip objects inside out-of-flow subtrees. When walking the tree backwards, looking for something in-flow, we may end up in an out-flow-subtree, so we cannot just examine the positioning scheme on the object itself. BUG=497710 R=dsinclair@chromium.org,jchaffraix@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196685

Patch Set 1 #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -8 lines)			Patch
A	LayoutTests/fast/multicol/dynamic/insert-spanner-after-abspos-subtree-crash.html	View	1 chunk	+19 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/multicol/dynamic/insert-spanner-after-abspos-subtree-crash-expected.txt	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/layout/LayoutMultiColumnFlowThread.cpp	View	2 chunks	+4 lines, -8 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149923009/1

5 years, 6 months ago (2015-06-08 16:23:28 UTC) #4

commit-bot: I haz the power

5 years, 6 months ago (2015-06-08 17:23:56 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196685

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages