Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1149913003: Revert "Roll Clang 233105-2:237739-1" (Closed)

Created:
5 years, 7 months ago by szager1
Modified:
5 years, 7 months ago
Reviewers:
Dirk Pranke, hans
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Roll Clang 233105-2:237739-1" This reverts commit 0e80c361a00645fbcdc8503225ccf12ebd1ef597, which appears to be causing blink test failures. Example: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20%28deps%29/builds/41877 TBR=hans@chromium.org,dpranke@chromium.org NOTRY=true NOPRESUBMIT=true BUG=483026 Committed: https://crrev.com/5b46c5cb02a8671c51f8a519f889e62ba9f41505 Cr-Commit-Position: refs/heads/master@{#330851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -53 lines) Patch
M build/common.gypi View 1 chunk +0 lines, -8 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/clang/blink_gc_plugin/JsonWriter.h View 3 chunks +15 lines, -3 lines 0 comments Download
M tools/clang/scripts/update.sh View 4 chunks +23 lines, -35 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
szager1
5 years, 7 months ago (2015-05-20 23:39:51 UTC) #1
hans
lgtm
5 years, 7 months ago (2015-05-20 23:40:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149913003/1
5 years, 7 months ago (2015-05-20 23:41:07 UTC) #4
hans
Added NOPRESUBMIT=true, because of 80+ long lines. Also added a BUG nbr.
5 years, 7 months ago (2015-05-20 23:47:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149913003/1
5 years, 7 months ago (2015-05-20 23:49:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 23:51:13 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5b46c5cb02a8671c51f8a519f889e62ba9f41505 Cr-Commit-Position: refs/heads/master@{#330851}
5 years, 7 months ago (2015-05-20 23:53:34 UTC) #10
Dirk Pranke
5 years, 7 months ago (2015-05-21 00:16:35 UTC) #11
Message was sent while issue was closed.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698