Vector ICs: Introduce Store and KeyedStore IC code stubs.

src/code-stubs.h

Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index 4c683edef54f422acb5580371e134512f9fa95d9..fb69648bfa5374a9fb72b13df0eb68d377d5f184 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -54,6 +54,10 @@ namespace internal {
   V(StubFailureTrampoline)                  \
   V(SubString)                              \
   V(ToNumber)                               \
+  V(VectorStoreICTrampoline)                \
+  V(VectorKeyedStoreICTrampoline)           \
+  V(VectorStoreIC)                          \
+  V(VectorKeyedStoreIC)                     \
   /* HydrogenCodeStubs */                   \
   V(AllocateHeapNumber)                     \
   V(ArrayNArgumentsConstructor)             \
@@ -2159,6 +2163,45 @@ class KeyedLoadICTrampolineStub : public LoadICTrampolineStub {
 };
 
 
+class VectorStoreICTrampolineStub : public PlatformCodeStub {
+ public:
+  VectorStoreICTrampolineStub(Isolate* isolate, const StoreICState& state)
+      : PlatformCodeStub(isolate) {
+    minor_key_ = state.GetExtraICState();
+  }
+
+  Code::Kind GetCodeKind() const override { return Code::STORE_IC; }
+
+  InlineCacheState GetICState() const final { return DEFAULT; }
+
+  ExtraICState GetExtraICState() const final {
+    return static_cast<ExtraICState>(minor_key_);
+  }
+
+ protected:
+  StoreICState state() const {
+    return StoreICState(static_cast<ExtraICState>(minor_key_));
+  }
+
+ private:
+  DEFINE_CALL_INTERFACE_DESCRIPTOR(VectorStoreICTrampoline);
+  DEFINE_PLATFORM_CODE_STUB(VectorStoreICTrampoline, PlatformCodeStub);
+};
+
+
+class VectorKeyedStoreICTrampolineStub : public VectorStoreICTrampolineStub {
+ public:
+  explicit VectorKeyedStoreICTrampolineStub(Isolate* isolate,

[Jakob Kummerow, 2015/05/22 11:38:17]

nit: "explicit" is unnecessary

[mvstanton, 2015/05/22 12:06:16]

Done.

+                                            const StoreICState& state)
+      : VectorStoreICTrampolineStub(isolate, state) {}
+
+  Code::Kind GetCodeKind() const override { return Code::KEYED_STORE_IC; }
+
+  DEFINE_PLATFORM_CODE_STUB(VectorKeyedStoreICTrampoline,
+                            VectorStoreICTrampolineStub);
+};
+
+
 class CallICTrampolineStub : public PlatformCodeStub {
  public:
   CallICTrampolineStub(Isolate* isolate, const CallICState& state)
@@ -2237,6 +2280,54 @@ class KeyedLoadICStub : public PlatformCodeStub {
 };
 
 
+class VectorStoreICStub : public PlatformCodeStub {
+ public:
+  explicit VectorStoreICStub(Isolate* isolate, const StoreICState& state)

[Jakob Kummerow, 2015/05/22 11:38:17]

nit: "explicit" is unnecessary

[mvstanton, 2015/05/22 12:06:16]

Done.

+      : PlatformCodeStub(isolate) {
+    minor_key_ = state.GetExtraICState();
+  }
+
+  void GenerateForTrampoline(MacroAssembler* masm);
+
+  virtual Code::Kind GetCodeKind() const override { return Code::STORE_IC; }

[Jakob Kummerow, 2015/05/22 11:38:17]

nit: the cool kids use only one of "virtual", "override", "final" these days,
specifically the most restrictive that's applicable. (Again several times
below.)

[mvstanton, 2015/05/22 12:06:16]

W00t, looks cleaner..thx.

+
+  virtual InlineCacheState GetICState() const final override { return DEFAULT; }
+
+  virtual ExtraICState GetExtraICState() const final override {
+    return static_cast<ExtraICState>(minor_key_);
+  }
+
+  DEFINE_CALL_INTERFACE_DESCRIPTOR(VectorStoreIC);
+  DEFINE_PLATFORM_CODE_STUB(VectorStoreIC, PlatformCodeStub);
+
+ protected:
+  void GenerateImpl(MacroAssembler* masm, bool in_frame);
+};
+
+
+class VectorKeyedStoreICStub : public PlatformCodeStub {
+ public:
+  explicit VectorKeyedStoreICStub(Isolate* isolate, const StoreICState& state)

[Jakob Kummerow, 2015/05/22 11:38:17]

nit: "explicit" is unnecessary

[mvstanton, 2015/05/22 12:06:16]

Done.

+      : PlatformCodeStub(isolate) {
+    minor_key_ = state.GetExtraICState();
+  }
+
+  void GenerateForTrampoline(MacroAssembler* masm);
+
+  virtual Code::Kind GetCodeKind() const override {
+    return Code::KEYED_STORE_IC;
+  }
+
+  virtual InlineCacheState GetICState() const final override { return DEFAULT; }
+
+  DEFINE_CALL_INTERFACE_DESCRIPTOR(VectorStoreIC);
+  DEFINE_PLATFORM_CODE_STUB(VectorKeyedStoreIC, PlatformCodeStub);
+
+ protected:
+  void GenerateImpl(MacroAssembler* masm, bool in_frame);
+};
+
+
 class DoubleToIStub : public PlatformCodeStub {
  public:
   DoubleToIStub(Isolate* isolate, Register source, Register destination,