Issue 1149893025: Make the StockList actually work in stocks2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1149893025: Make the StockList actually work in stocks2 (Closed)

Created:
5 years, 6 months ago by abarth-chromium

Modified:
5 years, 6 months ago

Reviewers:
Hixie, eseidel

CC:
gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Make the StockList actually work in stocks2 RenderScaffold needs to attach and detach its children when asked. R=eseidel@chromium.org, ianh@google.com Committed: https://chromium.googlesource.com/external/mojo/+/506ff42b21753092ebf54ac6a2b73cfe355b96ca

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	sky/examples/stocks2/lib/stock_app.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	sky/sdk/lib/framework/components2/scaffold.dart	View		1 chunk	+16 lines, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

eseidel

ScafoldSlots.values. otherwise lgtm. Can we make fn2 barf when you forget these?

5 years, 6 months ago (2015-06-04 22:49:24 UTC) #4

abarth-chromium

5 years, 6 months ago (2015-06-04 22:50:12 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
506ff42b21753092ebf54ac6a2b73cfe355b96ca (presubmit successful).