Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(162)

Issue 1149893021: Don't mark Text with ChildNeedsStyleRecalc. (Closed)

Created:
4 years, 11 months ago by esprehn
Modified:
4 years, 11 months ago
Reviewers:
Timothy Loh, ojan
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't mark Text with ChildNeedsStyleRecalc. Text can't have children, marking them with this bit just means leaving dirty bits in the tree. Only ContainerNode needs this bit set. A future patch will add ASSERTs that all bits are cleared. BUG=492730 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196294

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M Source/core/dom/ContainerNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
esprehn
4 years, 11 months ago (2015-06-02 04:57:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149893021/1
4 years, 11 months ago (2015-06-02 04:58:16 UTC) #4
ojan
lgtm
4 years, 11 months ago (2015-06-02 06:16:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149893021/1
4 years, 11 months ago (2015-06-02 06:29:26 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-06-02 07:53:07 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196294

Powered by Google App Engine
This is Rietveld 408576698