Fixes for GN Android build inputs/outputs

Fixes for GN Android build inputs/outputs

This makes the inputs and outputs of various Android targets match the dependency tree. There are still 565 errors remaining.

Renames datadeps -> data_deps in some places.

Committed: https://crrev.com/f883517afb9e390c40043dd67cea6fb0e69b608a
Cr-Commit-Position: refs/heads/master@{#332424}

[brettw, 2015-06-01 19:28:58]

brettw@chromium.org changed reviewers:
+ cjhopman@chromium.org

[brettw, 2015-06-01 19:29:03]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-01 19:32:49]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1149893018/1

[commit-bot: I haz the power, 2015-06-01 19:45:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-01 19:45:57]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)

[brettw, 2015-06-01 20:49:38]

Hold off on reviewing, I need to fix the dep cycle.

[cjhopman, 2015-06-01 20:53:45]

https://codereview.chromium.org/1149893018/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/1149893018/diff/1/build/config/android/rules....
build/config/android/rules.gni:1326: deps += [ ":$final_dex_target_name" ]
I don't think that this dep is needed. I think this target just uses the
final_dex_path string, it doesn't actually look at the file.

I'm pretty sure this would cause a dep cycle, too.

[brettw, 2015-06-01 21:05:41]

Thanks, turns out the line you pointed me to was the whole problem.

New snap up that seems to work locally. PTAL

[brettw, 2015-06-01 21:05:47]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-06-01 21:07:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1149893018/40001

[commit-bot: I haz the power, 2015-06-02 00:45:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-06-02 00:45:55]

Dry run: This issue passed the CQ dry run.

[cjhopman, 2015-06-02 17:00:33]

lgtm

[brettw, 2015-06-02 17:31:59]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2015-06-02 17:32:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1149893018/40001

[commit-bot: I haz the power, 2015-06-02 17:38:37]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-06-02 17:39:43]

Patchset 3 (id:??) landed as
https://crrev.com/f883517afb9e390c40043dd67cea6fb0e69b608a
Cr-Commit-Position: refs/heads/master@{#332424}