content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h - Issue 1149883011: bluetooth: Browser-side implementation of readValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

Issue 1149883011: bluetooth: Browser-side implementation of readValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@bluetooth-get-characteristic-initial

Patch Set: Address scheib's comments. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/common/bluetooth/bluetooth_messages.h ('k') | content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

diff --git a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

index 00580e4bbf43c249174b2b381f6b2f08765e4849..fad5cbad94002dd2ed06e4bad3d94762f3c625d9 100644

--- a/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

+++ b/content/shell/browser/layout_test/layout_test_bluetooth_adapter_provider.h

@@ -72,9 +72,9 @@ class LayoutTestBluetoothAdapterProvider {

// - |GetDeviceID| returns 2.

// - |IsPaired| returns true.

// - |GetUUIDs| returns a list with two UUIDs: "1800" and "1801".

- // - |GetGattServices| returns a list with two services "Generic Access" and

- // "Generic Attribute". "Generic Access" has a "Device Name" characteristic

- // and "Generic Attribute" has a "Service Changed" characteristic.

+ // - |GetGattServices| returns a list with one service "Generic Access".

+ // "Generic Access" has a "Device Name" characteristic, with a value of

+ // "Empty Mock Device Name", and a "Reconnection Address" characteristic.

scheib 2015/06/11 21:51:57 Point out here that a read of "Reconnection Addres

ortuno 2015/06/11 22:04:38 Done.

static scoped_ptr<testing::NiceMock<device::MockBluetoothDevice>>

GetEmptyDevice(device::MockBluetoothAdapter* adapter);