Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1149883004: Fix LCD coverage regression in GrPorterDuffXPFactory (Closed)

Created:
5 years, 7 months ago by Chris Dalton
Modified:
5 years, 7 months ago
Reviewers:
bsalomon, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix LCD coverage regression in GrPorterDuffXPFactory Fixes GrPorterDuffXPFactory to not use the blend table when getting info about the LCD coverage XP. BUG=skia: Committed: https://skia.googlesource.com/skia/+/3e2d59ef36e1b9a63e524cf1b27d5f7bcfb5ff0b

Patch Set 1 #

Patch Set 2 : rearrange test #

Patch Set 3 : clang warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -7 lines) Patch
M src/gpu/effects/GrPorterDuffXferProcessor.cpp View 1 2 2 chunks +14 lines, -7 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 10 chunks +56 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
Chris Dalton
5 years, 7 months ago (2015-05-22 20:43:27 UTC) #2
bsalomon
lgtm
5 years, 7 months ago (2015-05-22 20:49:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149883004/20001
5 years, 7 months ago (2015-05-22 20:50:01 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x86_64-Debug-Trybot/builds/1238)
5 years, 7 months ago (2015-05-22 20:51:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149883004/40001
5 years, 7 months ago (2015-05-22 20:58:51 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://skia.googlesource.com/skia/+/3e2d59ef36e1b9a63e524cf1b27d5f7bcfb5ff0b
5 years, 7 months ago (2015-05-22 21:04:40 UTC) #11
bungeman-skia
5 years, 7 months ago (2015-05-23 00:54:23 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1153803005/ by bungeman@google.com.

The reason for reverting is: Reverting this fix to revert
https://codereview.chromium.org/1124373002 .

Powered by Google App Engine
This is Rietveld 408576698