Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 1149873005: PPC: [es6] Spread in array literals (Closed)

Created:
5 years, 7 months ago by MTBrandyberry
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [es6] Spread in array literals Port 9502e91adbed48a546463aa848656d07619d14e6 Original commit message: This allows you to put iterables into your array literals and the will get spread into the array. let x = [0, ...range(1, 3)]; // [0, 1, 2] This is done by treating the array literal up to the first spread element as usual, including using a boiler plate array, and then appending the remaining expressions and rest expressions. R=arv@chromium.org, dstence@us.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/fc146e9e91350eb455e1a5bc71c46733413dd054 Cr-Commit-Position: refs/heads/master@{#28560}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -6 lines) Patch
M src/ppc/full-codegen-ppc.cc View 3 chunks +33 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 7 months ago (2015-05-21 14:51:21 UTC) #1
dstence
lgtm
5 years, 7 months ago (2015-05-21 14:56:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149873005/1
5 years, 7 months ago (2015-05-21 15:08:42 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 15:35:53 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 15:36:04 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc146e9e91350eb455e1a5bc71c46733413dd054
Cr-Commit-Position: refs/heads/master@{#28560}

Powered by Google App Engine
This is Rietveld 408576698