Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1149873003: easy-unlock: Fix AttemptAuth email CHECK crash (Closed)

Created:
5 years, 7 months ago by xiyuan
Modified:
5 years, 7 months ago
Reviewers:
Tim Song
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

easy-unlock: Fix AttemptAuth email CHECK crash - Return canonicalized email from GetUserEmail because sign-in manager gives back the Gaia email which is not necessarily the same as the one used on the login screen; - Sign-in manager gives empty user email when underlying refresh token is revoked. Bail out in this case. BUG=489890 Committed: https://crrev.com/80f645c4e3fae03b22838c19d67cb60c2fb93203 Cr-Commit-Position: refs/heads/master@{#330890}

Patch Set 1 #

Patch Set 2 : fix tests #

Total comments: 2

Patch Set 3 : run callback with failure #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M chrome/browser/signin/easy_unlock_service.cc View 1 2 1 chunk +16 lines, -5 lines 0 comments Download
M chrome/browser/signin/easy_unlock_service_regular.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
xiyuan
Speculative fix since I am not able to repro.
5 years, 7 months ago (2015-05-20 22:32:01 UTC) #2
Tim Song
https://codereview.chromium.org/1149873003/diff/20001/chrome/browser/signin/easy_unlock_service.cc File chrome/browser/signin/easy_unlock_service.cc (right): https://codereview.chromium.org/1149873003/diff/20001/chrome/browser/signin/easy_unlock_service.cc#newcode499 chrome/browser/signin/easy_unlock_service.cc:499: return; We should run the callback with a failure.
5 years, 7 months ago (2015-05-21 00:06:46 UTC) #3
xiyuan
https://codereview.chromium.org/1149873003/diff/20001/chrome/browser/signin/easy_unlock_service.cc File chrome/browser/signin/easy_unlock_service.cc (right): https://codereview.chromium.org/1149873003/diff/20001/chrome/browser/signin/easy_unlock_service.cc#newcode499 chrome/browser/signin/easy_unlock_service.cc:499: return; On 2015/05/21 00:06:46, Tim Song wrote: > We ...
5 years, 7 months ago (2015-05-21 01:32:12 UTC) #5
Tim Song
lgtm
5 years, 7 months ago (2015-05-21 01:53:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149873003/60001
5 years, 7 months ago (2015-05-21 02:53:11 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:60001)
5 years, 7 months ago (2015-05-21 04:39:57 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 04:42:24 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/80f645c4e3fae03b22838c19d67cb60c2fb93203
Cr-Commit-Position: refs/heads/master@{#330890}

Powered by Google App Engine
This is Rietveld 408576698