Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 1149863010: Build libclang_rt.asan-arm-android with stlport and API level 19. (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
hans
CC:
chromium-reviews, eugenis+clang_chromium.org, glider+clang_chromium.org, dmikurube+clang_chromium.org, ukai+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Build libclang_rt.asan-arm-android with stlport and API level 19. After https://codereview.chromium.org/951983002 ASan runtime library is built with libc++-enabled Android toolchain. There is an apparent unwinder bug there which is breaking ClusterFuzz. With this change, we will build ASan runtime library with stlport, and the rest of the code with libc++, which may sound scary, but should work fine, since ASan has C-only interface (except for new/delete operators). Also, ASan is no longer supported on JellyBean, so bump the API level of the Android toolchain to 19 (KitKat). Also, contains an oilpan compiler plugin tweak. BUG=492676 Patch by eugenis@chromium.org Original review URL: https://codereview.chromium.org/1161973004/ TBR=hans Committed: https://crrev.com/20f8a65d6b4c302a419ba0a1573fdf6ffa7d58d8 Cr-Commit-Position: refs/heads/master@{#332525}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/clang/scripts/update.sh View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Nico
5 years, 6 months ago (2015-06-02 22:58:00 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149863010/1
5 years, 6 months ago (2015-06-02 23:00:49 UTC) #3
hans
lgtm
5 years, 6 months ago (2015-06-03 00:51:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-03 03:13:55 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/20f8a65d6b4c302a419ba0a1573fdf6ffa7d58d8 Cr-Commit-Position: refs/heads/master@{#332525}
5 years, 6 months ago (2015-06-03 03:15:56 UTC) #7
chromium-reviews
5 years, 6 months ago (2015-06-03 23:41:48 UTC) #8
Message was sent while issue was closed.
thanks!

On Tue, Jun 2, 2015 at 3:58 PM,  <thakis@chromium.org> wrote:
> Reviewers: ,
>
> Description:
> Build libclang_rt.asan-arm-android with stlport and API level 19.
>
> After https://codereview.chromium.org/951983002 ASan runtime library
> is built with libc++-enabled Android toolchain. There is an apparent
> unwinder bug there which is breaking ClusterFuzz.
>
> With this change, we will build ASan runtime library with stlport,
> and the rest of the code with libc++, which may sound scary, but
> should work fine, since ASan has C-only interface (except for
> new/delete operators).
>
> Also, ASan is no longer supported on JellyBean, so bump the API level of the
> Android toolchain to 19 (KitKat).
>
> BUG=492676
> Patch by eugenis@chromium.org
> Original review URL: https://codereview.chromium.org/1161973004/
> TBR=hans
>
> Please review this at https://codereview.chromium.org/1149863010/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+3, -3 lines):
>   M tools/clang/scripts/update.sh
>
>
> Index: tools/clang/scripts/update.sh
> diff --git a/tools/clang/scripts/update.sh b/tools/clang/scripts/update.sh
> index
>
8ad19b5b9b6d99bd1a915365f05d603f71a3006f..86c6aed3b5a01541d404286920311ae2f2f19715
> 100755
> --- a/tools/clang/scripts/update.sh
> +++ b/tools/clang/scripts/update.sh
> @@ -11,7 +11,7 @@
>  CLANG_REVISION=238013
>
>  # This is incremented when pushing a new build of Clang at the same
> revision.
> -CLANG_SUB_REVISION=1
> +CLANG_SUB_REVISION=3
>
>  PACKAGE_VERSION="${CLANG_REVISION}-${CLANG_SUB_REVISION}"
>
> @@ -678,10 +678,10 @@ popd
>  if [[ -n "${with_android}" ]]; then
>    # Make a standalone Android toolchain.
>    ${ANDROID_NDK_DIR}/build/tools/make-standalone-toolchain.sh \
> -      --platform=android-14 \
> +      --platform=android-19 \
>        --install-dir="${LLVM_BUILD_DIR}/android-toolchain" \
>        --system=linux-x86_64 \
> -      --stl=libcxx \
> +      --stl=stlport \
>        --toolchain=arm-linux-androideabi-4.9
>
>    # Android NDK r9d copies a broken unwind.h into the toolchain, see
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698