src/factory.h - Issue 1149863005: Move hash code from hidden string to a private symbol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.h

Issue 1149863005: Move hash code from hidden string to a private symbol (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Fix global object hash code. This eated about 5% of weak collection performance Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.h

diff --git a/src/factory.h b/src/factory.h

index 8eaa216ee84646ba9f3d0d42c8c6d2188be5d69f..3b675f200b609160a288cf33fb3173cce381f6d0 100644

--- a/src/factory.h

+++ b/src/factory.h

@@ -233,7 +233,7 @@ class Factory final {

// Create a symbol.

Handle<Symbol> NewSymbol();

Handle<Symbol> NewPrivateSymbol();

- Handle<Symbol> NewPrivateOwnSymbol();

+ Handle<Symbol> NewPrivateOwnSymbol(Handle<Object> name);

// Create a global (but otherwise uninitialized) context.

Handle<Context> NewNativeContext();