Move hash code from hidden string to a private symbol

test/mjsunit/global-hash.js

-// Copyright 2008 the V8 project authors. All rights reserved.
+// Copyright 2015 the V8 project authors. All rights reserved.

[adamk, 2015/05/21 19:11:32]

Please use the short license header for new tests.

[Erik Corry, 2015/05/22 06:20:25]

Done.

 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
 //       with the distribution.
 //     * Neither the name of Google Inc. nor the names of its
 //       contributors may be used to endorse or promote products derived
 //       from this software without specific prior written permission.
 //
 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
-var str="ABC abc";
-var r = str.search('a');
-assertEquals(r, 4);
+var global = this;
 
-// Test for a lot of different string.
+assertTrue(typeof(global) === "object");  // Global object.
 
-var s = "";
+var s = new Set();
+s.add(global); // Puts a hash code on the global object.
+assertTrue(s.has(global));
 for (var i = 0; i < 100; i++) {
-  s += i;
-  var r = s.search(s);
-  assertEquals(0, r);
+  // Force rehash. Global object is placed according to the hash code that it
+  // gets in the C++ runtime.
+  s.add(i);
 }
+
+// Hopefully still findable using the JS hash code.

[adamk, 2015/05/21 19:11:32]

This test is good, but can you also add a cctest that detaches the proxy and
attaches to a new global to show that the hashcode remains the same across
"navigations".

[Erik Corry, 2015/05/22 06:20:25]

We already had this in test-api.cc, but it added the hash code from C++ so it
didn't test the case where we added from JS.  FIxed to do both.

+assertTrue(s.has(global));