Issue 1149823004: Set GOMAXPROCS=runtime.NumCPU().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1149823004: Set GOMAXPROCS=runtime.NumCPU(). (Closed)

Created:
5 years, 6 months ago by M-A Ruel

Modified:
5 years, 6 months ago

Reviewers:
Vadim Sh.

CC:
chromium-reviews, todd, andrew.wang, tandrii(chromium)

Base URL:
git@github.com:luci/luci-go@4_drop_tid

Target Ref:
refs/heads/master

Visibility:
Public.

Set GOMAXPROCS=runtime.NumCPU(). I had forgot the default was still 1. Andrew stated the default should switch in Go 1.5 and it's documented at https://golang.org/s/go15gomaxprocs but we are currently using 1.4.x. On a 4 cores MBP using the fake isolate server, duration of a drive run 100Mib/850 files went from ~17s to ~11s. On a 32 cores linux workstation, duration went from ~16s to 10.5s. R=vadimsh@chromium.org BUG= Committed: https://github.com/luci/luci-go/commit/b08de01629cbfd8318d7ca746c5795addd813264

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -0 lines)			Patch
M	client/cmd/isolate/common.go	View	2 chunks	+5 lines, -0 lines	0 comments	Download
M	client/cmd/isolated/common.go	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	client/cmd/swarming/common.go	View	1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

M-A Ruel

It makes the counter graphs in trace-viewer go a bit weirdo but I haven't yet ...

5 years, 6 months ago (2015-05-28 20:10:29 UTC) #2

M-A Ruel

5 years, 6 months ago (2015-05-29 01:26:17 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
b08de01629cbfd8318d7ca746c5795addd813264 (presubmit successful).