Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(628)

Issue 1149813002: Changes caching logic of mojo java apps (Closed)

Created:
5 years, 7 months ago by sky
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Changes caching logic of mojo java apps Previously we would extract all necessary files every time we ran the app. This is obviously unnecessary for any bundled apps. Now we extract only as necessary. R=ben@chromium.org, jcivelli@chromium.org BUG=none TEST=none Committed: https://crrev.com/128f7a0181634a89a35f681baab1d086d100e377 Cr-Commit-Position: refs/heads/master@{#330824} Committed: https://crrev.com/558c1539f144878aa57399981ef62b43c0a8c655 Cr-Commit-Position: refs/heads/master@{#330940}

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix test #

Patch Set 3 : bundled->cached #

Patch Set 4 : new log #

Patch Set 5 : format #

Patch Set 6 : trunk #

Patch Set 7 : fix #

Patch Set 8 : fix2 #

Patch Set 9 : fix3 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+356 lines, -98 lines) Patch
M mojo/runner/android/android_handler.cc View 1 2 3 4 4 chunks +76 lines, -4 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/AndroidHandler.java View 1 2 3 4 chunks +146 lines, -23 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/Bootstrap.java View 1 2 2 chunks +5 lines, -3 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/FileHelper.java View 1 2 3 4 chunks +92 lines, -55 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java View 1 2 4 chunks +9 lines, -4 lines 0 comments Download
M mojo/runner/android/bootstrap.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M mojo/runner/android/run_android_application_function.h View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M mojo/runner/android/tests/src/org/chromium/mojo/shell/ShellTestBase.java View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/runner/url_resolver.cc View 1 2 3 4 5 6 7 8 1 chunk +9 lines, -3 lines 0 comments Download
M mojo/runner/url_resolver_unittest.cc View 1 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 20 (6 generated)
sky
5 years, 7 months ago (2015-05-20 19:33:08 UTC) #1
Ben Goodger (Google)
https://codereview.chromium.org/1149813002/diff/1/mojo/runner/android/android_handler.cc File mojo/runner/android/android_handler.cc (right): https://codereview.chromium.org/1149813002/diff/1/mojo/runner/android/android_handler.cc#newcode76 mojo/runner/android/android_handler.cc:76: // Returns true if |url| denotes a bundled app. ...
5 years, 7 months ago (2015-05-20 20:04:11 UTC) #2
sky
https://codereview.chromium.org/1149813002/diff/1/mojo/runner/android/android_handler.cc File mojo/runner/android/android_handler.cc (right): https://codereview.chromium.org/1149813002/diff/1/mojo/runner/android/android_handler.cc#newcode76 mojo/runner/android/android_handler.cc:76: // Returns true if |url| denotes a bundled app. ...
5 years, 7 months ago (2015-05-20 20:27:25 UTC) #3
Ben Goodger (Google)
lgtm
5 years, 7 months ago (2015-05-20 20:49:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149813002/40001
5 years, 7 months ago (2015-05-20 20:53:05 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/65024)
5 years, 7 months ago (2015-05-20 21:02:22 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149813002/80001
5 years, 7 months ago (2015-05-20 21:58:31 UTC) #11
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 7 months ago (2015-05-20 22:57:07 UTC) #12
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/128f7a0181634a89a35f681baab1d086d100e377 Cr-Commit-Position: refs/heads/master@{#330824}
5 years, 7 months ago (2015-05-20 22:58:06 UTC) #13
sky
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1147203002/ by sky@chromium.org. ...
5 years, 7 months ago (2015-05-20 23:19:11 UTC) #14
sky
I reverted because of compile errors on windows. They are all sorted out and I'm ...
5 years, 7 months ago (2015-05-21 15:06:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149813002/160001
5 years, 7 months ago (2015-05-21 15:07:10 UTC) #18
commit-bot: I haz the power
Committed patchset #9 (id:160001)
5 years, 7 months ago (2015-05-21 15:11:26 UTC) #19
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 15:12:21 UTC) #20
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/558c1539f144878aa57399981ef62b43c0a8c655
Cr-Commit-Position: refs/heads/master@{#330940}

Powered by Google App Engine
This is Rietveld 408576698