content/renderer/gpu/render_widget_compositor.cc - Issue 1149803002: cc: Make single-thread renderer compositor always synchronous.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/gpu/render_widget_compositor.cc

Issue 1149803002: cc: Make single-thread renderer compositor always synchronous. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: syncsinglethread: . Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/trees/layer_tree_host_impl.cc ('K') | « content/renderer/gpu/compositor_dependencies.h ('k') | content/renderer/gpu/render_widget_compositor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/gpu/render_widget_compositor.cc

diff --git a/content/renderer/gpu/render_widget_compositor.cc b/content/renderer/gpu/render_widget_compositor.cc

index c8400037005e70c95d7bbd8922b64a11360f1fba..0a8e994aeb0aa7cf126ccc8bde68e77ae8e2a260 100644

--- a/content/renderer/gpu/render_widget_compositor.cc

+++ b/content/renderer/gpu/render_widget_compositor.cc

@@ -315,8 +315,9 @@ void RenderWidgetCompositor::Initialize() {

settings.impl_side_painting;

settings.renderer_settings.allow_antialiasing &=

!cmd->HasSwitch(cc::switches::kDisableCompositedAntialiasing);

- settings.single_thread_proxy_scheduler =

- compositor_deps_->UseSingleThreadScheduler();

+ // Using the scheduler in layout tests (the only time we're single threaded

+ // here) introduces additional composite steps that create flakiness.

+ settings.single_thread_proxy_scheduler = false;

enne (OOO) 2015/05/20 19:05:23 Can you leave a comment here that this means that

danakj 2015/05/20 19:07:38 Done.

// These flags should be mirrored by UI versions in ui/compositor/.

settings.initial_debug_state.show_debug_borders =