Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: cc/trees/layer_tree_host_impl.cc

Issue 1149803002: cc: Make single-thread renderer compositor always synchronous. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: syncsinglethread: . Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_pixeltest_synchronous.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl.cc
diff --git a/cc/trees/layer_tree_host_impl.cc b/cc/trees/layer_tree_host_impl.cc
index 248e744c417d87cb610e4d24bcb22d861d3b6cb0..aca271f256ba63d29cf948cccb8fc7dcfbba4df0 100644
--- a/cc/trees/layer_tree_host_impl.cc
+++ b/cc/trees/layer_tree_host_impl.cc
@@ -2118,7 +2118,7 @@ void LayerTreeHostImpl::CreateResourceAndTileTaskWorkerPool(
image_target == GL_TEXTURE_EXTERNAL_OES,
context_provider->ContextCapabilities().gpu.egl_image_external);
- if (settings_.use_zero_copy || IsSynchronousSingleThreaded()) {
+ if (settings_.use_zero_copy) {
*resource_pool =
ResourcePool::Create(resource_provider_.get(), image_target);
@@ -2128,6 +2128,11 @@ void LayerTreeHostImpl::CreateResourceAndTileTaskWorkerPool(
}
if (settings_.use_one_copy) {
+ // Synchronous single-threaded mode depends on tiles being ready to
+ // draw when raster is complete. Therefore, it must use one of zero
+ // copy, software raster, or GPU raster.
+ DCHECK(!IsSynchronousSingleThreaded());
+
// We need to create a staging resource pool when using copy rasterizer.
*staging_resource_pool =
ResourcePool::Create(resource_provider_.get(), image_target);
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_pixeltest_synchronous.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698