Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4424)

Unified Diff: chrome/browser/chrome_browser_application_mac.mm

Issue 11498008: RenderWidget popup should be a NSWindow so it can go outside the main window. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Removed cancelChildPopups Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_browser_application_mac.mm
diff --git a/chrome/browser/chrome_browser_application_mac.mm b/chrome/browser/chrome_browser_application_mac.mm
index d6d9291992bb2c6fed31b2d4ec37ab048db15ea0..c5fa6aa07ae8f508bf5e324a47bed0d3c5bbf828 100644
--- a/chrome/browser/chrome_browser_application_mac.mm
+++ b/chrome/browser/chrome_browser_application_mac.mm
@@ -231,7 +231,6 @@ void SwizzleInit() {
- (id)init {
SwizzleInit();
if ((self = [super init])) {
- eventHooks_.reset([[NSMutableArray alloc] init]);
}
// Sanity check to alert if overridden methods are not supported.
@@ -412,14 +411,6 @@ void SwizzleInit() {
return [super sendAction:anAction to:aTarget from:sender];
}
-- (void)addEventHook:(id<CrApplicationEventHookProtocol>)handler {
- [eventHooks_ addObject:handler];
-}
-
-- (void)removeEventHook:(id<CrApplicationEventHookProtocol>)handler {
- [eventHooks_ removeObject:handler];
-}
-
- (BOOL)isHandlingSendEvent {
return handlingSendEvent_;
}
@@ -428,14 +419,6 @@ void SwizzleInit() {
handlingSendEvent_ = handlingSendEvent;
}
-- (void)sendEvent:(NSEvent*)event {
- base::mac::ScopedSendingEvent sendingEventScoper;
- for (id<CrApplicationEventHookProtocol> handler in eventHooks_.get()) {
- [handler hookForEvent:event];
- }
- [super sendEvent:event];
-}
-
// NSExceptions which are caught by the event loop are logged here.
// NSException uses setjmp/longjmp, which can be very bad for C++, so
// we attempt to track and report them.

Powered by Google App Engine
This is Rietveld 408576698