chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h - Issue 11498008: RenderWidget popup should be a NSWindow so it can go outside the main window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h

Issue 11498008: RenderWidget popup should be a NSWindow so it can go outside the main window. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Shouldn't be calling setParentWindow Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller.h ('k') | content/browser/renderer_host/render_widget_host_view_mac.h » ('j') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h

diff --git a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h

index 1317c13bcf3eb79f759b985e0e7addd29b69e742..925f6c1d536fc3a704c93aa23e0f38c57bff85e1 100644

--- a/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h

+++ b/chrome/browser/ui/cocoa/bookmarks/bookmark_bar_folder_controller.h

@@ -30,7 +30,7 @@

// Bookmark bar folder controller chains are torn down in two ways:

// 1. Clicking "outside" the folder (see use of

- // CrApplicationEventHookProtocol in the bookmark bar controller).

+ // CrEventHookProtocol in the bookmark bar controller).

// 2. Engaging a different folder (via hover over or explicit click).

// In either case, the BookmarkButtonControllerProtocol method