Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 11498008: RenderWidget popup should be a NSWindow so it can go outside the main window. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index d821a8e11b077368e52b7b1f114ad2a87de79721..9a2adbc769a6ef437d55d288693f8a152d2d60b5 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -1448,7 +1448,10 @@ void WebContentsImpl::ShowCreatedWidget(int route_id,
if (is_fullscreen) {
widget_host_view->InitAsFullscreen(GetRenderWidgetHostView());
} else {
- widget_host_view->InitAsPopup(GetRenderWidgetHostView(), initial_pos);
+ WebContentsViewDelegate* delegate =
+ GetContentClient()->browser()->GetWebContentsViewDelegate(this);
+ widget_host_view->InitAsPopup(GetRenderWidgetHostView(),
+ initial_pos, delegate);
}
RenderWidgetHostImpl* render_widget_host_impl =

Powered by Google App Engine
This is Rietveld 408576698