content/browser/renderer_host/render_widget_host_view_guest.h - Issue 11498008: RenderWidget popup should be a NSWindow so it can go outside the main window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_guest.h

Issue 11498008: RenderWidget popup should be a NSWindow so it can go outside the main window. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm ('K') | « chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm ('k') | content/browser/renderer_host/render_widget_host_view_guest.cc » ('j') | content/browser/renderer_host/render_widget_host_view_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_guest.h

diff --git a/content/browser/renderer_host/render_widget_host_view_guest.h b/content/browser/renderer_host/render_widget_host_view_guest.h

index 2f2947a2f5b7bf528984c6b6165a7d6c9b341641..f42ca7b74344ad214b97cfd7eef77dfbf8bfddda 100644

--- a/content/browser/renderer_host/render_widget_host_view_guest.h

+++ b/content/browser/renderer_host/render_widget_host_view_guest.h

@@ -58,7 +58,8 @@ class CONTENT_EXPORT RenderWidgetHostViewGuest

// RenderWidgetHostViewPort implementation.

virtual void InitAsPopup(RenderWidgetHostView* parent_host_view,

- const gfx::Rect& pos) OVERRIDE;

+ const gfx::Rect& pos,

+ WebContentsViewDelegate* delegate = NULL) OVERRIDE;

Avi (use Gerrit) 2012/12/10 20:52:06 I don't believe we allow default arguments like th

keishi 2012/12/11 05:09:14 Done.

virtual void InitAsFullscreen(

RenderWidgetHostView* reference_host_view) OVERRIDE;

virtual void WasShown() OVERRIDE;