chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h - Issue 11498008: RenderWidget popup should be a NSWindow so it can go outside the main window.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h

Issue 11498008: RenderWidget popup should be a NSWindow so it can go outside the main window. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm » ('j') | chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h

diff --git a/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h b/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h

index 78320d9281458b26313245ecf53f24cefc84e194..276e5a6a79810763aba5e07697dd932fa835660d 100644

--- a/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h

+++ b/chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h

@@ -30,6 +30,7 @@ class ChromeWebContentsViewDelegateMac

virtual NSObject<RenderWidgetHostViewMacDelegate>*

CreateRenderWidgetHostViewDelegate(

content::RenderWidgetHost* render_widget_host) OVERRIDE;

+ virtual NSWindow* CreatePopupWindow() OVERRIDE;

virtual content::WebDragDestDelegate* GetDragDestDelegate() OVERRIDE;

virtual void ShowContextMenu(

const content::ContextMenuParams& params,