RenderWidget popup should be a NSWindow so it can go outside the main window.

content/browser/renderer_host/render_widget_host_view_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_mac.h"
 
 #include <QuartzCore/QuartzCore.h>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 37 matching lines @@
 #import "third_party/mozilla/ComplexTextInputPanel.h"
 #include "third_party/skia/include/core/SkColor.h"
 #import "ui/base/cocoa/fullscreen_window_manager.h"
 #import "ui/base/cocoa/underlay_opengl_hosting_window.h"
 #include "ui/base/keycodes/keyboard_codes.h"
 #include "ui/base/layout.h"
 #include "ui/gfx/point.h"
 #include "ui/gfx/rect_conversions.h"
 #include "ui/gfx/size_conversions.h"
 #include "ui/gfx/scoped_ns_graphics_context_save_gstate_mac.h"
+#include "ui/gfx/native_widget_types.h"
 #include "ui/surface/io_surface_support_mac.h"
 #include "webkit/plugins/npapi/webplugin.h"
+#include "content/public/browser/web_contents_view_delegate.h"

[Avi (use Gerrit), 2012/12/10 20:52:06]

alphabetical

[keishi, 2012/12/11 05:09:14]

Done.

 
 using content::BackingStoreMac;
 using content::BrowserAccessibility;
 using content::BrowserAccessibilityManager;
 using content::EditCommand;
 using content::NativeWebKeyboardEvent;
 using content::RenderViewHostImpl;
 using content::RenderWidgetHostImpl;
 using content::RenderWidgetHostViewMac;
 using content::RenderWidgetHostViewMacEditCommandHelper;
@@ skipping 69 matching lines @@
 - (void)keyEvent:(NSEvent*)theEvent wasKeyEquivalent:(BOOL)equiv;
 - (void)cancelChildPopups;
 - (void)windowDidChangeBackingProperties:(NSNotification*)notification;
 - (void)windowChangedGlobalFrame:(NSNotification*)notification;
 - (void)checkForPluginImeCancellation;
 - (void)updateTabBackingStoreScaleFactor;
 - (NSRect)firstViewRectForCharacterRange:(NSRange)theRange
                              actualRange:(NSRangePointer)actualRange;
 @end
 
+

[Avi (use Gerrit), 2012/12/10 20:52:06]

stray return

[keishi, 2012/12/11 05:09:14]

Done.

 // NSEvent subtype for scroll gestures events.
 static const short kIOHIDEventTypeScroll = 6;
 
 // A window subclass that allows the fullscreen window to become main and gain
 // keyboard focus. This is only used for pepper flash. Normal fullscreen is
 // handled by the browser.
 @interface PepperFlashFullscreenWindow : UnderlayOpenGLHostingWindow
 @end
 
 @implementation PepperFlashFullscreenWindow
@@ skipping 164 matching lines @@
 
 ///////////////////////////////////////////////////////////////////////////////
 // RenderWidgetHostViewMac, RenderWidgetHostView implementation:
 
 void RenderWidgetHostViewMac::InitAsChild(
     gfx::NativeView parent_view) {
 }
 
 void RenderWidgetHostViewMac::InitAsPopup(
     RenderWidgetHostView* parent_host_view,
-    const gfx::Rect& pos) {
+    const gfx::Rect& pos,
+    WebContentsViewDelegate* delegate) {
   bool activatable = popup_type_ == WebKit::WebPopupTypeNone;
   [cocoa_view_ setCloseOnDeactivate:YES];
   [cocoa_view_ setCanBeKeyView:activatable ? YES : NO];
   [parent_host_view->GetNativeView() addSubview:cocoa_view_];
 
   NSPoint origin_global = NSPointFromCGPoint(pos.origin().ToCGPoint());
   if ([[NSScreen screens] count] > 0) {
     origin_global.y = [[[NSScreen screens] objectAtIndex:0] frame].size.height -
         pos.height() - origin_global.y;
   }
-  NSPoint origin_window =
-      [[cocoa_view_ window] convertScreenToBase:origin_global];
-  NSPoint origin_view =
-      [cocoa_view_ convertPoint:origin_window fromView:nil];
-  NSRect initial_frame = NSMakeRect(origin_view.x,
-                                    origin_view.y,
-                                    pos.width(),
-                                    pos.height());
-  [cocoa_view_ setFrame:initial_frame];
+
+  popup_window_.reset(delegate->CreatePopupWindow());
+  [popup_window_ setFrame:NSMakeRect(origin_global.x, origin_global.y,
+                                     pos.width(), pos.height()) display:YES];

[Avi (use Gerrit), 2012/12/10 20:52:06]

Wrap "display:YES" to the next line; it gets lost here.

[keishi, 2012/12/11 05:09:14]

Done.

+  [popup_window_ setLevel:NSPopUpMenuWindowLevel];
+  [popup_window_ setReleasedWhenClosed:NO];
+
+  [cocoa_view_ setCanBeKeyView:YES];

[Avi (use Gerrit), 2012/12/10 20:52:06]

It seems silly to me to call -setCanBeKeyView above on line 340 and then re-set
it here. Pick one.

[keishi, 2012/12/11 05:09:14]

Done.

+  [cocoa_view_ setFrame:[[popup_window_ contentView] bounds]];
+  [popup_window_ makeKeyAndOrderFront:nil];
+  [[popup_window_ contentView] addSubview:cocoa_view_];

[Avi (use Gerrit), 2012/12/10 20:52:06]

You may want to set the bindings on the cocoa_view_ to bind its size to the
superview. This will help later...

[keishi, 2012/12/11 05:09:14]

Done.

+  [popup_window_ setParentWindow:[parent_host_view->GetNativeView() window]];
 }
 
 // This function creates the fullscreen window and hides the dock and menubar if
 // necessary. Note, this codepath is only used for pepper flash when
 // pp::FlashFullScreen::SetFullscreen() is called. If
 // pp::FullScreen::SetFullscreen() is called then the entire browser window
 // will enter fullscreen instead.
 void RenderWidgetHostViewMac::InitAsFullscreen(
     RenderWidgetHostView* reference_host_view) {
   fullscreen_parent_host_view_ =
@@ skipping 96 matching lines @@
     // consider Cocoa coordinate system is upside-down and also multi-screen.
     NSPoint origin_global = NSPointFromCGPoint(rect.origin().ToCGPoint());
     if ([[NSScreen screens] count] > 0) {
       NSSize size = NSMakeSize(rect.width(), rect.height());
       size = [cocoa_view_ convertSize:size toView:nil];
       NSScreen* screen =
           static_cast<NSScreen*>([[NSScreen screens] objectAtIndex:0]);
       origin_global.y =
           NSHeight([screen frame]) - size.height - origin_global.y;
     }
-
-    // Then |origin_global| is converted to client coordinate system.
-    DCHECK([cocoa_view_ window]);
-    NSPoint origin_window =
-        [[cocoa_view_ window] convertScreenToBase:origin_global];
-    NSPoint origin_view =
-        [[cocoa_view_ superview] convertPoint:origin_window fromView:nil];
-    NSRect frame = NSMakeRect(origin_view.x, origin_view.y,
-                              rect.width(), rect.height());
-    [cocoa_view_ setFrame:frame];
+    [cocoa_view_ setFrame:NSMakeRect(0.0, 0.0, rect.width(), rect.height())];
+    [popup_window_ setFrame:NSMakeRect(origin_global.x, origin_global.y,
+                                       rect.width(), rect.height())
+                    display:YES];

[Avi (use Gerrit), 2012/12/10 20:52:06]

This is wrong because rect.size() is in view coordinates, yet you use it here
for both view and screen coordinate systems.

My advice is to bind the cocoa_view_ to its superview (as I advised above), and
here convert the size to global coordinates and resize the popup window. The
view, having been bound to its superview, will follow suit and resize too.

[keishi, 2012/12/11 05:09:14]

When will a view size and a screen size be different? Is it for hi-dpi screens?
Could you tell me which method to use?

[Avi (use Gerrit), 2012/12/11 05:14:20]

Yes, the primary time they differ is on hi-dpi screens.

In general you use -[NSView convert(type): toView:] to convert from one view's
coordinate system to another view's. Please study up on how each view has its
own coordinate system.

For here, because you have a view in a window, and you always want to have the
view be the same size as the window, please bind them. That way, you can set the
window size, and the view will automatically resize with it.

   } else {
     DCHECK([[cocoa_view_ superview] isKindOfClass:[BaseView class]]);
     BaseView* superview = static_cast<BaseView*>([cocoa_view_ superview]);
     gfx::Rect rect2 = [superview flipNSRectToRect:[cocoa_view_ frame]];
     rect2.set_width(rect.width());
     rect2.set_height(rect.height());
     [cocoa_view_ setFrame:[superview flipRectToNSRect:rect2]];
   }
 }
 
@@ skipping 234 matching lines @@
       [static_cast<AcceleratedPluginView*>(subview)
           onRenderWidgetHostViewGone];
     }
   }
 
   // We've been told to destroy.
   [cocoa_view_ retain];
   [cocoa_view_ removeFromSuperview];
   [cocoa_view_ autorelease];
 
+  [popup_window_ close];
+  popup_window_.autorelease();
+
   [fullscreen_window_manager_ exitFullscreenMode];
   fullscreen_window_manager_.reset();
   [pepper_fullscreen_window_ close];
 
   // This can be called as part of processing the window's responder
   // chain, for instance |-performKeyEquivalent:|.  In that case the
   // object needs to survive until the stack unwinds.
   pepper_fullscreen_window_.autorelease();
 
   // We get this call just before |render_widget_host_| deletes
@@ skipping 2634 matching lines @@
   if (!string) return NO;
 
   // If the user is currently using an IME, confirm the IME input,
   // and then insert the text from the service, the same as TextEdit and Safari.
   [self confirmComposition];
   [self insertText:string];
   return YES;
 }
 
 @end