content/renderer/render_frame_proxy.h - Issue 1149793002: Detach old frame on WebFrame::swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_proxy.h

Issue 1149793002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_proxy.h

diff --git a/content/renderer/render_frame_proxy.h b/content/renderer/render_frame_proxy.h

index b2ac60f2855023baba149f5f2f57420f87c239ad..f3bb8b73dbdf43bab256a956d26a7dde3a88bed9 100644

--- a/content/renderer/render_frame_proxy.h

+++ b/content/renderer/render_frame_proxy.h

@@ -117,7 +117,9 @@ class CONTENT_EXPORT RenderFrameProxy

blink::WebRemoteFrame* web_frame() { return web_frame_; }

// blink::WebRemoteFrameClient implementation:

+ // TODO(lfg): Remove this method once the blink patch lands.

virtual void frameDetached();

+ virtual void frameDetached(DetachType type);

virtual void postMessageEvent(

blink::WebLocalFrame* sourceFrame,

blink::WebRemoteFrame* targetFrame,