content/renderer/render_frame_impl.h - Issue 1149793002: Detach old frame on WebFrame::swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/render_frame_impl.h

Issue 1149793002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/render_frame_impl.h

diff --git a/content/renderer/render_frame_impl.h b/content/renderer/render_frame_impl.h

index 1a88dcb817d699e3b495c711a6b5eac1da39faee..d2506ee4b52dbdda9113b0f96abf96594dc58616 100644

--- a/content/renderer/render_frame_impl.h

+++ b/content/renderer/render_frame_impl.h

@@ -367,7 +367,9 @@ class CONTENT_EXPORT RenderFrameImpl

const blink::WebString& name,

blink::WebSandboxFlags sandboxFlags);

virtual void didDisownOpener(blink::WebLocalFrame* frame);

+ // TODO(lfg): Remove this method once the blink patch lands.

virtual void frameDetached(blink::WebFrame* frame);

+ virtual void frameDetached(blink::WebFrame* frame, DetachType type);

virtual void frameFocused();

virtual void willClose(blink::WebFrame* frame);

virtual void didChangeName(blink::WebLocalFrame* frame,