Detach old frame on WebFrame::swap.

components/html_viewer/html_document.cc

Index: components/html_viewer/html_document.cc
diff --git a/components/html_viewer/html_document.cc b/components/html_viewer/html_document.cc
index 4f678954e1683bd86c7e6c070b814e99e598b4de..786f6885a643341dc2399e2fe47c8c3c87e570f9 100644
--- a/components/html_viewer/html_document.cc
+++ b/components/html_viewer/html_document.cc
@@ -255,6 +255,11 @@ blink::WebFrame* HTMLDocument::createChildFrame(
 }
 
 void HTMLDocument::frameDetached(blink::WebFrame* frame) {
+  frameDetached(frame, DetachType::Remove);
+}
+
+void HTMLDocument::frameDetached(blink::WebFrame* frame, DetachType type) {
+  DCHECK(type == DetachType::Remove);

[Charlie Reis, 2015/06/01 23:41:46]

DCHECK_EQ?

[lfg, 2015/06/02 16:00:01]

Can't because base::logging doesn't know how to print the enum types.

[Charlie Reis, 2015/06/02 17:05:27]

Acknowledged.

   if (frame->parent())
     frame->parent()->removeChild(frame);