components/html_viewer/html_document.h - Issue 1149793002: Detach old frame on WebFrame::swap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/html_viewer/html_document.h

Issue 1149793002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressing Daniel's comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/html_viewer/html_document.h

diff --git a/components/html_viewer/html_document.h b/components/html_viewer/html_document.h

index 873d14e89485838f5efef9d92071abed39589927..76178409fa5f50a2ce0348cd6771e6e9905734a3 100644

--- a/components/html_viewer/html_document.h

+++ b/components/html_viewer/html_document.h

@@ -89,6 +89,7 @@ class HTMLDocument : public blink::WebViewClient,

const blink::WebString& frameName,

blink::WebSandboxFlags sandboxFlags);

virtual void frameDetached(blink::WebFrame*);

+ virtual void frameDetached(blink::WebFrame*, DetachType);

dcheng 2015/06/01 21:41:11 Nit: name these parameters to follow Chrome style.

lfg 2015/06/01 21:46:04 Done.

virtual blink::WebCookieJar* cookieJar(blink::WebLocalFrame* frame);

virtual blink::WebNavigationPolicy decidePolicyForNavigation(

const NavigationPolicyInfo& info);