Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: components/html_viewer/html_document.cc

Issue 1149793002: Detach old frame on WebFrame::swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressing Daniel's comments Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/html_viewer/html_document.cc
diff --git a/components/html_viewer/html_document.cc b/components/html_viewer/html_document.cc
index 4f678954e1683bd86c7e6c070b814e99e598b4de..c36f5d5a5b7c0d09fd4614fed245771fccec26f8 100644
--- a/components/html_viewer/html_document.cc
+++ b/components/html_viewer/html_document.cc
@@ -1,4 +1,4 @@
-// Copyright 2014 The Chromium Authors. All rights reserved.
+
dcheng 2015/06/01 21:41:11 Typo?
lfg 2015/06/01 21:46:04 Oops.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
@@ -255,6 +255,11 @@ blink::WebFrame* HTMLDocument::createChildFrame(
}
void HTMLDocument::frameDetached(blink::WebFrame* frame) {
+ frameDetached(frame, DetachType::Remove);
+}
+
+void HTMLDocument::frameDetached(blink::WebFrame* frame, DetachType type) {
+ DCHECK(type == DetachType::Remove);
if (frame->parent())
frame->parent()->removeChild(frame);

Powered by Google App Engine
This is Rietveld 408576698