Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1149773003: Revert of Revert of Hook up more import/exports in natives. (Closed)

Created:
5 years, 7 months ago by Yang
Modified:
5 years, 7 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Revert of Hook up more import/exports in natives. (patchset #1 id:1 of https://codereview.chromium.org/1154743003/) Reason for revert: Unrelated failure that was uncovered by this CL has been fixed (https://codereview.chromium.org/1152243002/) Original issue's description: > Revert of Hook up more import/exports in natives. (patchset #3 id:40001 of https://codereview.chromium.org/1154483002/) > > Reason for revert: > [Sheriff] Speculative revert for gc stress failures: > http://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/481 > > Original issue's description: > > Hook up more import/exports in natives. > > > > R=jkummerow@chromium.org > > > > Committed: https://crrev.com/7a918ac9658d11778f39593bfcc19d7c506defd9 > > Cr-Commit-Position: refs/heads/master@{#28573} > > > > Committed: https://crrev.com/e13a39dd7f4062898709d7c68900677df0513995 > > Cr-Commit-Position: refs/heads/master@{#28578} > > TBR=jkummerow@chromium.org,erik.corry@gmail.com,yangguo@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > > Committed: https://crrev.com/eb0024d1dbdda5f51b006dd54887404ee6c5cbfc > Cr-Commit-Position: refs/heads/master@{#28584} TBR=jkummerow@chromium.org,erik.corry@gmail.com,machenbach@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/5cb925e448e3646f6f3aa1e6baf9344846a750d8 Cr-Commit-Position: refs/heads/master@{#28608}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+714 lines, -520 lines) Patch
M src/array.js View 12 chunks +36 lines, -31 lines 0 comments Download
M src/array-iterator.js View 3 chunks +10 lines, -5 lines 0 comments Download
M src/arraybuffer.js View 2 chunks +3 lines, -4 lines 0 comments Download
M src/bootstrapper.cc View 2 chunks +4 lines, -1 line 0 comments Download
M src/collection.js View 7 chunks +17 lines, -8 lines 0 comments Download
M src/collection-iterator.js View 3 chunks +4 lines, -4 lines 0 comments Download
M src/date.js View 7 chunks +10 lines, -12 lines 0 comments Download
M src/generator.js View 3 chunks +14 lines, -5 lines 0 comments Download
M src/harmony-array.js View 12 chunks +23 lines, -17 lines 0 comments Download
M src/harmony-array-includes.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-object.js View 3 chunks +13 lines, -2 lines 0 comments Download
M src/harmony-reflect.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-tostring.js View 1 chunk +1 line, -1 line 0 comments Download
M src/harmony-typedarray.js View 17 chunks +57 lines, -20 lines 0 comments Download
M src/i18n.js View 33 chunks +83 lines, -67 lines 0 comments Download
M src/iterator-prototype.js View 1 chunk +1 line, -1 line 0 comments Download
M src/json.js View 5 chunks +6 lines, -4 lines 0 comments Download
M src/macros.py View 1 chunk +1 line, -1 line 0 comments Download
M src/math.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/messages.js View 13 chunks +33 lines, -28 lines 0 comments Download
M src/object-observe.js View 7 chunks +17 lines, -9 lines 0 comments Download
M src/prologue.js View 1 chunk +183 lines, -14 lines 0 comments Download
M src/promise.js View 2 chunks +2 lines, -2 lines 0 comments Download
M src/proxy.js View 4 chunks +21 lines, -9 lines 0 comments Download
M src/regexp.js View 16 chunks +38 lines, -35 lines 0 comments Download
M src/string.js View 13 chunks +26 lines, -20 lines 0 comments Download
M src/string-iterator.js View 5 chunks +15 lines, -6 lines 0 comments Download
M src/symbol.js View 5 chunks +14 lines, -5 lines 0 comments Download
M src/third_party/fdlibm/fdlibm.js View 1 chunk +1 line, -1 line 0 comments Download
M src/typedarray.js View 4 chunks +25 lines, -26 lines 0 comments Download
M src/uri.js View 1 chunk +1 line, -1 line 0 comments Download
M src/v8natives.js View 17 chunks +47 lines, -173 lines 0 comments Download
M src/weak-collection.js View 2 chunks +2 lines, -2 lines 0 comments Download
M test/mjsunit/compiler/jsnatives.js View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of Revert of Hook up more import/exports in natives.
5 years, 7 months ago (2015-05-26 07:23:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149773003/1
5 years, 7 months ago (2015-05-26 07:23:47 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-26 07:24:25 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-26 07:24:32 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cb925e448e3646f6f3aa1e6baf9344846a750d8
Cr-Commit-Position: refs/heads/master@{#28608}

Powered by Google App Engine
This is Rietveld 408576698