Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Issue 1149763007: Ship the NotificationOptions vibrate property. (Closed)

Created:
5 years, 7 months ago by Sanghyun Park
Modified:
5 years, 5 months ago
CC:
blink-reviews, peter+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Ship the NotificationOptions vibrate property This is part of the following Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/hLhTAOXfRTo Authors can now supply a vibration pattern similar to "navigator.vibrate()", which is to be applied when a Notification gets shown. BUG=442132 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196670

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/notifications/NotificationOptions.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Sanghyun Park
Hi, Peter. Could you review this patch? :)
5 years, 6 months ago (2015-06-08 11:15:47 UTC) #2
Peter Beverloo
On 2015/06/08 11:15:47, Sanghyun Park wrote: > Hi, Peter. > Could you review this patch? ...
5 years, 6 months ago (2015-06-08 11:19:12 UTC) #3
Sanghyun Park
On 2015/06/08 11:19:12, Peter Beverloo wrote: > On 2015/06/08 11:15:47, Sanghyun Park wrote: > > ...
5 years, 6 months ago (2015-06-08 11:21:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1149763007/20001
5 years, 6 months ago (2015-06-08 11:22:35 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-08 12:27:20 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196670

Powered by Google App Engine
This is Rietveld 408576698